Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point set kwargs for DVGeometryMulti #154

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Point set kwargs for DVGeometryMulti #154

merged 4 commits into from
Sep 7, 2022

Conversation

sseraj
Copy link
Contributor

@sseraj sseraj commented Sep 6, 2022

Purpose

I made two changes related to addPointSet kwargs for DVGeometryMulti:

  1. Added an option to pass kwargs for the triangulated surface mesh
  2. Pass kwargs from DVGeometryMulti's addPointSet to the component addPointSet

I also changed mutable default assignments to be inside functions. These were not causing any issues to my knowledge, but this should be safer.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner September 6, 2022 16:28
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #154 (4ceb66c) into main (787a96d) will increase coverage by 0.00%.
The diff coverage is 73.33%.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   63.89%   63.90%           
=======================================
  Files          47       47           
  Lines       11745    11757   +12     
=======================================
+ Hits         7505     7513    +8     
- Misses       4240     4244    +4     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeoMulti.py 89.77% <73.33%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joanibal joanibal merged commit c5cda6d into main Sep 7, 2022
@marcomangano marcomangano deleted the multi-kwargs branch September 7, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants