Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in test training and update training references #200

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

eirikurj
Copy link
Contributor

Purpose

Fix a bug in test 21 for DVGeometry. Reference training data for tests is also updated. Aside from minor drift, previous values are mostly fine. However, the structure of the reference data made it impossible to diff.
Tests are trained in docker on the u22-gcc-ompi-latest.

Expected time until merged

1-2 days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner May 10, 2023 09:07
@eirikurj eirikurj requested review from hajdik and anilyil May 10, 2023 09:07
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #200 (f8cd959) into main (7ca8f36) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   64.87%   64.88%           
=======================================
  Files          47       47           
  Lines       11941    11942    +1     
=======================================
+ Hits         7747     7748    +1     
  Misses       4194     4194           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil merged commit 32634fb into main May 11, 2023
11 checks passed
@anilyil anilyil deleted the updateTests branch May 11, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants