-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for writeSurfaceTecplot
to get surface from DVGeo
#209
Conversation
writeSurfaceTecplot
to get surface from DVGeo
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 47 47
Lines 12018 12018
=======================================
+ Hits 7783 7784 +1
+ Misses 4235 4234 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name _getSurfacePoints
is too similar to _getSurfaceVertices
. Can you modify _getSurfaceVertices
to add the fromDVGeo
argument instead of adding a new function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. One minor thing: can you add what the default behavior is when fromDVGeo
is set to None
? Does it just write the original coordinates? To someone looking at the current state of the code w/o any of its history, it would be difficult to understand the different behavior.
Sure, please check that my explanation makes sense to you. As far as I can see, if |
Yeah set surface just gets an initial copy of the vertices, which is what is saved in DVCon. The explanation is correct. |
Purpose
The
writeSurfaceSTL
inDVConstraints
has the ability to write out a surface that is not stored in aDVConstraints
object but in the associated DVGeo. This PR just extends that functionality to thewriteSurfaceTecplot
function.Expected time until merged
1 day
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable