Fix CZ encoding

[Cogax]

Czech registry seems to be stored in latin-1 encoding but read in utf-8 which leads to wrong bank names.

[Natim]

Are you sure it's doesn't just needs to be read in utf-8 rather than latin-1?

[Natim]

@Cogax could you try this branch? #194

I checked all encoding and they appear to be set to UTF-8

$ file -i schwifty/bank_registry/*
schwifty/bank_registry/generated_at.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_ba.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_be.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_ch.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_cz.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_de.json: text/plain; charset=us-ascii
schwifty/bank_registry/generated_ee.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_es.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_fi.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_ge.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_hr.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_hu.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_it.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_kz.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_lt.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_lu.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_lv.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_md.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_nl.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_no.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_pl.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_ro.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_rs.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_se.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_si.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_sk.json: application/json; charset=us-ascii
schwifty/bank_registry/generated_ua.json: text/plain; charset=utf-8
schwifty/bank_registry/manual_ad.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_ae.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_bg.json:    application/json; charset=utf-8
schwifty/bank_registry/manual_cr.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_cy.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_dk.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_es.json:    application/json; charset=utf-8
schwifty/bank_registry/manual_fr.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_gb.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_gr.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_ie.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_il.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_is.json:    application/json; charset=utf-8
schwifty/bank_registry/manual_it.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_mc.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_pt.json:    application/json; charset=utf-8
schwifty/bank_registry/manual_sa.json:    application/json; charset=us-ascii
schwifty/bank_registry/manual_tr.json:    application/json; charset=us-ascii
schwifty/bank_registry/README.md:         text/plain; charset=us-ascii

[Natim]

Validated locally. I will add a test.

>>> [bank["name"] for bank in schwifty.registry.get("bank") if bank["country_code"] == "CZ"]
['Komerční banka, a.s.', 'Československá obchodní banka, a. s.', 'MONETA Money Bank, a.s.', 'ČESKÁ NÁRODNÍ BANKA', 'Česká spořitelna, a.s.', 'Fio banka, a.s.', 'Citfin, spořitelní družstvo', 'TRINITY BANK a.s.', 'ČSOB Hypoteční banka, a.s.', 'Peněžní dům, spořitelní družstvo', 'Artesa, spořitelní družstvo', 'Banka CREDITAS a.s.', 'NEY spořitelní družstvo', 'Podnikatelská družstevní záložna', 'Citibank Europe plc, organizační složka', 'UniCredit Bank Czech Republic and Slovakia, a.s.', 'Air Bank a.s.', 'BNP Paribas Personal Finance SA, odštěpný závod', 'PKO BP S.A., Czech Branch', 'ING Bank N.V.', 'Max banka a.s.', 'Národní rozvojová banka, a.s.', 'Raiffeisenbank a.s.', 'J&T BANKA, a.s.', 'PPF banka a.s.', 'COMMERZBANK Aktiengesellschaft, pobočka Praha', 'mBank S.A., organizační složka', 'BNP Paribas S.A., pobočka Česká republika', 'Partners Banka, a.s.', 'Všeobecná úverová banka a.s., pobočka Praha', 'Sberbank CZ, a.s. v likvidaci', 'Deutsche Bank Aktiengesellschaft Filiale Prag, organizační složka', 'Raiffeisen stavební spořitelna a.s.', 'ČSOB Stavební spořitelna, a.s.', 'MONETA Stavební Spořitelna, a.s.', 'Modrá pyramida stavební spořitelna, a.s.', 'Volksbank Raiffeisenbank Nordoberpfalz eG pobočka Cheb', 'Oberbank AG pobočka Česká republika', 'Stavební spořitelna České spořitelny, a.s.', 'Česká exportní banka, a.s.', 'HSBC Continental Europe, Czech Republic', 'Sparkasse Oberlausitz-Niederschlesien', 'FAS finance company s.r.o.', 'Payment execution s.r.o.', 'Bank of China (CEE) Ltd. Prague Branch', 'Bank of Communications Co., Ltd., Prague Branch odštěpný závod', 'Industrial and Commercial Bank of China Limited, Prague Branch, odštěpný závod', 'B-Efekt a.s.', 'BESTPAY s.r.o.', 'Multitude Bank p.l.c.']

[Natim]

Here is the suggested test https://github.com/LN-Zap/schwifty/pull/2/files

[Cogax]

Thanks @Natim ! So do you think we can merge this PR?

[Natim]

I believe @mdomke will do it once he is back. You can use this PR LN-Zap/schwifty-cli#1 in the meantime indeed until the next release.