New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERF: Loosen pytest-seed and add a file for collection broken seeds #80
Open
NiMlr
wants to merge
52
commits into
mdp-toolkit:master
Choose a base branch
from
NiMlr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
4c893a3
ERF: Loosen pytest-seed and add a file for collection broken seeds
NiMlr 634eb55
ERF: more info for listing broken seeds
NiMlr 4d15670
ERF: update broken seeds
NiMlr e352775
ERF: update broken seeds
NiMlr 3985f0e
Update README
NiMlr b7c8de8
Rename README to README.md
NiMlr ae47980
Update README.md
NiMlr 0a3cf4e
Update README.md
NiMlr 30917d3
Update README.md
NiMlr a656531
Update README.md
NiMlr bd7831b
Update README.md
NiMlr 780ec95
Update README.md
NiMlr adb7c11
Update README.md
NiMlr 40c6765
Update README.md
NiMlr 4e998b0
Update README.md
NiMlr c4e7fd0
Update README.md
NiMlr a0418db
Update README.md
NiMlr 36e3a10
Update README.md
NiMlr e5de8ca
Update README.md
NiMlr 0ec9cad
Update README.md
NiMlr 66cbfff
Update README.md
NiMlr c2745d9
Update README.md
NiMlr 921064e
Update README.md
NiMlr a947cef
Update README.md
NiMlr 586b7c0
Update README.md
NiMlr 642d1e9
Update README.md
NiMlr 40183b5
Update README.md
NiMlr f4cab0d
Update README.md
NiMlr c6a4129
Update README.md
NiMlr 49b5816
Update README.md
NiMlr 06b0129
Update README.md
NiMlr a3c57a8
Update README.md
NiMlr 1e37065
Update README.md
NiMlr ccc7f0a
Update README.md
NiMlr 027d648
Update README.md
NiMlr 44a4666
Update README.md
NiMlr bbe63ef
Update README.md
NiMlr b3ee9be
Update README.md
NiMlr 78ec443
Update README.md
NiMlr 24f18bf
Update README.md
NiMlr 5f21186
Update README.md
NiMlr b1e01b1
Update README.md
NiMlr 8f40edc
Update README.md
NiMlr f55de33
Update README.md
NiMlr 1f8d476
Update README.md
NiMlr 7a8f29a
Update README.md
NiMlr 281490c
Update README.md
NiMlr d3afe60
Update README.md
NiMlr a72ac06
Update README.md
NiMlr 873fa45
Update README.md
NiMlr 8819c5e
Update README.md
NiMlr d494805
Update and rename README.md to README
NiMlr File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# This file is a collection of pytest-seeds that led to at least one of the | ||
# tests failing, and it provides a way to spot faulty functionality. | ||
# | ||
# A description of how to gather the seeds is given at | ||
# https://mdp-toolkit.github.io/development.html#how-to-handle-failed-tests. | ||
# | ||
# Please list them in the format: | ||
# SEED, FUNCTIONALITY, TEST-NAME, PYTHON-VERSION, NUMPY-VERSION, SCIPY-VERSION, SKLEARN-VERSION | ||
|
||
1766368184, SFANode, , 3.8.0.final.0, , 1.4.1, 0.23.0 | ||
400700733, VartimeCovariance, VartimeCovarianceMatrix1, 3.5.6.final.0, , 1.4.1, 0.22.2.post1 | ||
317438632, RBM, RBM_bv_learning, 3.6.7.final.0, , 1.4.1, 0.23.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
Please refer to the online documentation at https://mdpdocs.readthedocs.io | ||
The legacy documentation is still available at http://mdp-toolkit.sourceforge.net | ||
Please refer to the online documentation at https://mdp-toolkit.github.io | ||
The source code is available at https://github.com/mdp-toolkit/mdp-toolkit |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a clear specification of how to store the seeds. So, we should first find a broken seed so the we can add an example here. Anyway, we should explain that a failing test can be reproduced like this:
The values for
N
,XXX
andYYY
can be read out of the pytest report after a failed test run.Here an example of failing seed (from: 664d688)
(note that to get a failure for this specific test you need to comment out the
@pytest.mark.skip
decorator in the file)So maybe it is enough if we just add the above line to this file. When we discover other failing seed/tests, we can add the lines to reproduce here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think extending the section on testing in the docs is a better place for this or should at least be considered additionally?