Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the digest as algorithm parameter #62

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Include the digest as algorithm parameter #62

merged 1 commit into from
Sep 22, 2016

Conversation

btalbot
Copy link
Contributor

@btalbot btalbot commented Sep 22, 2016

Include the digest as algorithm parameter in URI returned by TOTP#provisioning_uri
closes #61

mdp
mdp approved these changes Sep 22, 2016
View reviewed changes
Copy link
Owner

@mdp mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdp mdp merged commit 4d65df8 into mdp:master Sep 22, 2016
@btalbot btalbot deleted the bug/no_alg_in_uri branch August 30, 2017 23:23
@tristanmorgan tristanmorgan mentioned this pull request Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdp mdp mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

algorithm (digest) is missing from provisioning_uri
2 participants
@btalbot @mdp