Hardhat: stop estimating gas, log like ganache #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"If you are using ethers.js, then those values need to be set in each call/deployment. "The gasPrice that can be set in the config doesn't have an effect when you are using ethers. We need to update that section of the docs to make it clearer that that's the case." source: https://twitter.com/fvictorio_nan/status/1470503282909093890 I confirmed with fvictorio that the same advice applies to the gas limit as well. I confirmed that, before this change, the log from the hardhat benchmark run showed a call to eth_estimateGas, and after this change it did not.
mds1
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
With this GAS_LIMIT change in place, Hardhat is no longer estimating gas before running the transaction, and, by my measurements, its benchmark run time is down from 40 seconds to 8 when starting with a cache, and from 23 minutes to 15 when starting without a cache.