Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat: stop estimating gas, log like ganache #10

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Hardhat: stop estimating gas, log like ganache #10

merged 2 commits into from
Jan 28, 2022

Commits on Jan 27, 2022

  1. measure separate setup/execution like ganache

    @feuGeneA
    feuGeneA committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    efd5dc4 View commit details
    Browse the repository at this point in the history

  2. explicitly apply GAS_LIMIT to shutdownSystem() 

    "If you are using ethers.js, then those values need to be set in each
call/deployment.

"The gasPrice that can be set in the config doesn't have an effect when
you are using ethers. We need to update that section of the docs to make
it clearer that that's the case."

source: https://twitter.com/fvictorio_nan/status/1470503282909093890

I confirmed with fvictorio that the same advice applies to the gas limit
as well.

I confirmed that, before this change, the log from the hardhat benchmark
run showed a call to eth_estimateGas, and after this change it did not.
    @feuGeneA
    feuGeneA committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    5241824 View commit details
    Browse the repository at this point in the history