mobile optimized #63
Open
mobile optimized #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mds1
reviewed
May 8, 2024
Comment on lines
+69
to
+80
| <div className="max-sm:pr-4 max-sm:col-span-8 col-span-6"> | ||
| <div>{name}</div> | ||
| <Copyable | ||
| className="text-secondary text-sm" | ||
| content={formatAddress(addr)} | ||
| textToCopy={addr} | ||
| /> | ||
| </div> | ||
| <div className="max-sm:col-span-2 col-span-3 pr-4 max-sm:text-right"> | ||
| {baseStackAddress.exists ? 'Yes' : 'No'} | ||
| </div> | ||
| <div className="max-sm:col-span-2 col-span-3 max-sm:text-right">{targetStackAddress?.exists ? 'Yes' : 'No'}</div> |
There was a problem hiding this comment.
This definitely looks much nicer on mobile! Can we tweak it to stay left aligned on larger screens though? I think it's right aligned on larger screens. (Eventually I want to make the chain names "sticky" so they are always visible when scrolling, which is when you would notice this more easily)
There was a problem hiding this comment.
Just pushed a commit to the refactor/automated branch which adds the stickiness :)
|
Nice! You want me to left-align it? |
|
Yea let's try it. I think that will look nicer since the chain name headers are left aligned, e.g. on desktop currently it looks like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized metadata and EVM stack addresses diff tables for mobile view