Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing setuptools dependency in 0.7.2 #206

Closed
ryanking opened this issue Feb 15, 2023 · 2 comments · Fixed by #207
Closed

missing setuptools dependency in 0.7.2 #206

ryanking opened this issue Feb 15, 2023 · 2 comments · Fixed by #207
Assignees
Labels

Comments

@ryanking
Copy link

When trying to upgrade from 0.7.1 to 0.7.2, I started getting errors from pyfaidx like:

../../named_caches/pex_root/venvs/s/ca27a750/venv/lib/python3.8/site-packages/pyfaidx/__init__.py:21: in <module>
    from pkg_resources import get_distribution
E   ModuleNotFoundError: No module named 'pkg_resources'

It seems that in the switch to pyproject.toml, the dependency on setuptools got droped.

@mdshw5 mdshw5 self-assigned this Feb 16, 2023
@mdshw5 mdshw5 added the bug label Feb 16, 2023
mdshw5 added a commit that referenced this issue Feb 16, 2023
Long-term solution once I stop supporting python < 3.8 should be to switch to https://docs.python.org/3/library/importlib.metadata.html#module-importlib.metadata
mdshw5 added a commit that referenced this issue Feb 16, 2023
mdshw5 added a commit that referenced this issue Feb 16, 2023
@mdshw5 mdshw5 linked a pull request Feb 16, 2023 that will close this issue
@mdshw5
Copy link
Owner

mdshw5 commented Feb 16, 2023

@ryanking Thanks for reporting this, and I'm sorry you had this issue. I clearly overlooked the version string mechanism I was using (and didn't have any tests for!) when I switched to pyproject.toml. I've created a new release (v0.7.2.1) which is currently making its way though CI/CD. I should be installable from PyPI in the next 15 minutes now. Can you test this version and make sure it fixes the issue for you?

@ryanking
Copy link
Author

@mdshw5 updated and working locally, testing in CI should work too.

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants