Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rotate pypi creds #127

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Fix/rotate pypi creds #127

merged 7 commits into from
Sep 16, 2021

Conversation

glow-mdsol
Copy link
Member

  • owing to travis-ci being a bad boy we needed to rotate the credentials
  • took the opportunity to move to GH actions for CI

isparks
isparks approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@isparks isparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments.

@isparks
Copy link
Collaborator

isparks commented Sep 16, 2021

Ok to merge, I see one failing CI check (CI/Build and publish) is this expected?

@glow-mdsol
Copy link
Member Author

yeah, just working out the nits of the GitHub actions workflow

@glow-mdsol
Copy link
Member Author

Ok, think we're good now

@isparks
Copy link
Collaborator

isparks commented Sep 16, 2021

OK. Merging.

@isparks isparks merged commit 799cbc2 into develop Sep 16, 2021
@isparks isparks deleted the fix/rotate_pypi_creds branch September 16, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isparks isparks isparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glow-mdsol @isparks