Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cosmiconfig returns null if no config found #285

Merged
merged 2 commits into from
Mar 17, 2021
Merged

fix: cosmiconfig returns null if no config found #285

merged 2 commits into from
Mar 17, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Mar 17, 2021 •
edited
Loading

ChristianMurphy
ChristianMurphy approved these changes Mar 17, 2021
View reviewed changes
packages/eslint-plugin-mdx/src/rules/helpers.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@JounQin JounQin merged commit 52d712a into master Mar 17, 2021
@JounQin JounQin deleted the fix/remark-config branch March 17, 2021 04:06
@JounQin JounQin mentioned this pull request Mar 17, 2021
Closed
@JounQin
Copy link
Member Author

JounQin commented Mar 17, 2021

@mdx-js/releasers @wooorm Please help to release. 🤣

@chenxsan chenxsan mentioned this pull request Mar 17, 2021
Closed
@kelvindecosta
Copy link

Hey!

I'm just wondering whether this fix is for / related to this error:

Oops! Something went wrong! :(

ESLint: 7.22.0

TypeError: Cannot read property 'config' of null
Occurred while linting README.md:1
    at getRemarkProcessor (/path/to/my/project/node_modules/eslint-plugin-mdx/lib/cjs.js:370:22)
    at Program (/path/to/my/project/node_modules/eslint-plugin-mdx/lib/cjs.js:423:39)

@JounQin
Copy link
Member Author

JounQin commented Mar 17, 2021

@kelvindecosta Yes, you can add an empty remarkConfig temporarily as workaround like ab7a3af (#4326)

@JounQin
Copy link
Member Author

JounQin commented Mar 17, 2021

@wooorm Or release this patch version first.

@YutaUra
Copy link

YutaUra commented Mar 17, 2021

I have the same issue!

YutaUra added a commit to ycu-engine/ycu-engine.github.io that referenced this pull request Mar 17, 2021
@YutaUra
patch related:mdx-js/eslint-mdx/pull/285
4246759
This was referenced Mar 17, 2021
Closed
Closed
@JounQin JounQin mentioned this pull request Mar 17, 2021
Closed
@JounQin
Copy link
Member Author

JounQin commented Mar 17, 2021

@mdx-js/releasers Please...

@ChristianMurphy ChristianMurphy mentioned this pull request Mar 17, 2021
Closed
@wooorm
Copy link
Member

wooorm commented Mar 18, 2021

released.

@JounQin I’ve said this a couple days ago already: you do not have to ping me several times a day.
I have other things to do, too. I’ll get to it.

@JounQin
Copy link
Member Author

JounQin commented Mar 18, 2021 •
edited
Loading

I think this is a serious bugfix which affects a lot of users.

Is there any other releasers can help you? Or, is that possible to give me the permission to release these two packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm Awaiting requested review from wooorm

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JounQin @kelvindecosta @YutaUra @wooorm @ChristianMurphy