fix: code block in jsx should be ignored #208
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #207
Code blocks in jsx should always be ignored, but I don't know if it is good to drop them in AST, or is there any better way?
Additionally,
<details><summary >Override element states</summary>
is parsed as a single jsx node fromremark-mdx
, it could not be handled correctly at https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-mdx/src/traverse.ts#L41 which expects<details>
and<summary >Override element states</summary>
separately, is that possible to do it inremark-mdx
? @wooormThe temporary workaround is:
What means that depends on user to make sure that
<details>
is a single jsx node.