Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump (dev)Dependencies, fix: consider first jsx node as open tag - close #272 #273

Merged
merged 8 commits into from
Feb 20, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Feb 20, 2021

fix #272

the parsed remark-mdx jsx nodes are not precise, but it will be resolved in v2

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #273 (a997291) into master (dd0227f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          424       436   +12     
  Branches        79        82    +3     
=========================================
+ Hits           424       436   +12     
Impacted Files Coverage Δ
packages/eslint-mdx/src/helper.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/regexp.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/traverse.ts 100.00% <100.00%> (ø)
...slint-plugin-mdx/src/rules/no-jsx-html-comments.ts 100.00% <100.00%> (ø)
...lint-plugin-mdx/src/rules/no-unescaped-entities.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/rules/remark.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0227f...a997291. Read the comment docs.

@JounQin
Copy link
Member Author

JounQin commented Feb 20, 2021

@wooorm @ChristianMurphy

@wooorm
Copy link
Member

wooorm commented Feb 20, 2021

@JounQin What’s the reason for the ping? A code review or something else? If the first: I’ve never really looked into the code of this project much and this PR also seems to contain several code-style changes, so this looks okay but I’m not really sure what part I should focus on?

packages/eslint-mdx/src/parser.ts Outdated Show resolved Hide resolved
packages/eslint-mdx/src/traverse.ts Outdated Show resolved Hide resolved
@JounQin
Copy link
Member Author

JounQin commented Feb 20, 2021

@wooorm I've highlighted the important changes at #273 (comment) .

@wooorm
Copy link
Member

wooorm commented Feb 20, 2021

I’m generally fine with this, because I trust your opinion more that mine on this project! I’d guess the // prettier-ignore line above it might be a bad sign though, so maybe some extra tests to check that it works would be good

@JounQin JounQin merged commit cb846e9 into master Feb 20, 2021
@JounQin JounQin deleted the fix/jsx_nodes branch February 20, 2021 18:11
@JounQin
Copy link
Member Author

JounQin commented Feb 20, 2021

I’m generally fine with this, because I trust your opinion more that mine on this project! I’d guess the // prettier-ignore line above it might be a bad sign though, so maybe some extra tests to check that it works would be good

Did you mean the following istanbul ignore next? It should be moved to https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-mdx/src/traverse.ts#L80 actually.

And // prettier-ignore is used to prevent istanbul ignore next comment moving to wrong place.


See 5813078

@JounQin
Copy link
Member Author

JounQin commented Feb 20, 2021

@mdx-js/releasers Please help to release a new version.

@JounQin
Copy link
Member Author

JounQin commented Feb 22, 2021

@wooorm Any time to cut a release?

@wooorm
Copy link
Member

wooorm commented Feb 22, 2021

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Parsing error: unknown jsx node when newlines are between nested jsx nodes
4 participants