Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Node 17 #1804

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Update for Node 17 #1804

merged 1 commit into from
Nov 9, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Nov 9, 2021

  • Add support for Node 17 to the node loader
    (backport wooorm/xdm@e72b930)
  • Turn of a preact/compat test, which throws in Node 17 as its missing an
    export map
  • Turn tests off for Node 17 in @mdx-js/register, as it requires deasync
    which hasn’t been updated with a Node 17 build yet.

@wooorm
Update for Node 17
dc7c386 
*   Add support for Node 17 to the node loader
    (backport wooorm/xdm@e72b930)
*   Turn of a `preact/compat` test, which throws in Node 17 as its missing an
    export map
*   Turn tests off for Node 17 in `@mdx-js/register`, as it requires `deasync`
    which hasn’t been updated with a Node 17 build yet.
@vercel
Copy link

vercel bot commented Nov 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/24NVpMudY3DGBEoe3xeT7EhihMZU
✅ Preview: https://mdx-git-node-loader-17-mdx.vercel.app

@wooorm wooorm merged commit dc37949 into main Nov 9, 2021
@wooorm wooorm deleted the node-loader-17 branch November 9, 2021 16:03
ChristianMurphy
ChristianMurphy reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

packages/mdx/test/compile.js Show resolved Hide resolved
packages/node-loader/lib/index.js
/**
* @param {string} url
* @param {unknown} context
* @param {Function} defaultLoad
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Node have a more specific type for the default loader?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API for defaultLoad is the same as this load function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a recursive interface for the type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but I don’t see a bunch of value. It just got redesigned. It’ll be redesigned again. The API is unstable: https://nodejs.org/api/esm.html#loadurl-context-defaultload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooorm @ChristianMurphy