Object spread #2328

remcohaszing · 2023-07-17T19:05:33Z

This affects the assignment of _components. For JSX see syntax-tree/estree-util-build-jsx#8.

vercel · 2023-07-17T19:05:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mdx	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2023 7:08pm

This affects the assignment of `_components`. For JSX see syntax-tree/estree-util-build-jsx#8

remcohaszing · 2023-07-17T19:08:23Z

packages/mdx/lib/plugin/recma-jsx-rewrite.js

                  // make sure it’s defined.
                  {
                    type: 'LogicalExpression',
                    operator: '||',
                    left: parameters[0],
                    right: {type: 'ObjectExpression', properties: []}
                  }
-                : parameters[0]


This else was reached, but removing it doesn’t change the test output and I’m not sure what it’s for.

I don’t remember and I don’t know from looking at just this PR

remcohaszing · 2023-07-17T19:08:55Z

packages/rollup/test/index.js

@@ -34,7 +34,7 @@ test('@mdx-js/rollup', async () => {

  assert.equal(
    output[0].map ? output[0].map.mappings : undefined,
-    ';;;MAAaA,OAAU,GAAA,MAAAC,GAAA,CAAAC,QAAA,EAAA;AAAQ,EAAA,QAAA,EAAA,QAAA;;;;;;;AAE7B,IAAA,QAAA,EAAA,CAAA,SAAA,EAAAD,GAAA,CAAA,OAAA,EAAA,EAAA,CAAA,CAAA;;;;;;;;;;;;',
+    ';;;MAAaA,OAAU,GAAA,MAAAC,GAAA,CAAAC,QAAA,EAAA;AAAQ,EAAA,QAAA,EAAA,QAAA;;;;;;;;AAE7B,IAAA,QAAA,EAAA,CAAA,SAAA,EAAAD,GAAA,CAAA,OAAA,EAAA,EAAA,CAAA,CAAA;;;;;;;;;;;;',


I honestly have no idea what this change means.

I guess another identifier was added

remcohaszing · 2023-07-17T19:09:11Z

packages/mdx/test/compile.js

@@ -1045,6 +1049,42 @@ test('jsx', async (t) => {
    }
  )

+  await t.test(
+    'should combine passing `components` w/ props and a provider',


A test combining these was missing.

codecov-commenter · 2023-07-17T19:11:34Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d2ce50f) 100.00% compared to head (98debd0) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #2328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2246      2239    -7     
  Branches         4         4           
=========================================
- Hits          2246      2239    -7

Impacted Files	Coverage Δ
packages/mdx/lib/plugin/recma-jsx-rewrite.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

wooorm · 2023-07-17T19:11:55Z

So 8 should land first there before this?

remcohaszing · 2023-07-17T19:22:28Z

Both convert Object.assign() in separate unrelated places. It doesn’t matter in what order they land, but both need to land to close #2310.

wooorm · 2023-07-18T15:48:56Z

packages/mdx/lib/plugin/recma-jsx-rewrite.js

                  // make sure it’s defined.
                  {
                    type: 'LogicalExpression',
                    operator: '||',
                    left: parameters[0],
                    right: {type: 'ObjectExpression', properties: []}
                  }
-                : parameters[0]


I don’t remember and I don’t know from looking at just this PR

wooorm · 2023-07-18T15:50:22Z

packages/rollup/test/index.js

@@ -34,7 +34,7 @@ test('@mdx-js/rollup', async () => {

  assert.equal(
    output[0].map ? output[0].map.mappings : undefined,
-    ';;;MAAaA,OAAU,GAAA,MAAAC,GAAA,CAAAC,QAAA,EAAA;AAAQ,EAAA,QAAA,EAAA,QAAA;;;;;;;AAE7B,IAAA,QAAA,EAAA,CAAA,SAAA,EAAAD,GAAA,CAAA,OAAA,EAAA,EAAA,CAAA,CAAA;;;;;;;;;;;;',
+    ';;;MAAaA,OAAU,GAAA,MAAAC,GAAA,CAAAC,QAAA,EAAA;AAAQ,EAAA,QAAA,EAAA,QAAA;;;;;;;;AAE7B,IAAA,QAAA,EAAA,CAAA,SAAA,EAAAD,GAAA,CAAA,OAAA,EAAA,EAAA,CAAA,CAAA;;;;;;;;;;;;',


I guess another identifier was added

remcohaszing added 🦋 type/enhancement This is great to have 🤞 phase/open Post is being triaged manually labels Jul 17, 2023

remcohaszing requested review from wooorm and ChristianMurphy July 17, 2023 19:05

ChristianMurphy approved these changes Jul 17, 2023

View reviewed changes

Change Object.assign() calls to object spread

98debd0

This affects the assignment of `_components`. For JSX see syntax-tree/estree-util-build-jsx#8

remcohaszing force-pushed the object-spread branch from 1291c30 to 98debd0 Compare July 17, 2023 19:07

vercel bot deployed to Preview July 17, 2023 19:08 View deployment

remcohaszing commented Jul 17, 2023

View reviewed changes

wooorm approved these changes Jul 18, 2023

View reviewed changes

wooorm merged commit 8a56312 into main Jul 18, 2023
10 checks passed

wooorm deleted the object-spread branch July 18, 2023 15:51

wooorm added 💪 phase/solved Post is done and removed 🤞 phase/open Post is being triaged manually labels Jul 18, 2023

wooorm mentioned this pull request Oct 18, 2023

Use spread syntax to create shallow clones #2310

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Object spread #2328

Object spread #2328

remcohaszing commented Jul 17, 2023

vercel bot commented Jul 17, 2023 •

edited

remcohaszing Jul 17, 2023

wooorm Jul 18, 2023

remcohaszing Jul 17, 2023

wooorm Jul 18, 2023

remcohaszing Jul 17, 2023

codecov-commenter commented Jul 17, 2023 •

edited

wooorm commented Jul 17, 2023

remcohaszing commented Jul 17, 2023

wooorm Jul 18, 2023

wooorm Jul 18, 2023

Object spread #2328

Object spread #2328

Conversation

remcohaszing commented Jul 17, 2023

vercel bot commented Jul 17, 2023 • edited

remcohaszing Jul 17, 2023

Choose a reason for hiding this comment

wooorm Jul 18, 2023

Choose a reason for hiding this comment

remcohaszing Jul 17, 2023

Choose a reason for hiding this comment

wooorm Jul 18, 2023

Choose a reason for hiding this comment

remcohaszing Jul 17, 2023

Choose a reason for hiding this comment

codecov-commenter commented Jul 17, 2023 • edited

Codecov Report

wooorm commented Jul 17, 2023

remcohaszing commented Jul 17, 2023

wooorm Jul 18, 2023

Choose a reason for hiding this comment

wooorm Jul 18, 2023

Choose a reason for hiding this comment

vercel bot commented Jul 17, 2023 •

edited

codecov-commenter commented Jul 17, 2023 •

edited