Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @babel/core to the peer dependencies #775

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Sep 9, 2019

@babel/core is used here:

https://github.com/mdx-js/mdx/blob/master/packages/babel-plugin-apply-mdx-type-props/index.js#L1

That said, I think the dependency could be removed if you were using something like that instead:

const {types: t} = api;

Cf here for an example:

https://github.com/arcanis/babel-plugin-lazy-import/blob/master/index.js#L15

@vercel
Copy link

vercel bot commented Sep 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-arcanis-patch-1.mdx.now.sh

@vercel vercel bot temporarily deployed to staging September 9, 2019 07:21 Inactive
@johno
Copy link
Member

johno commented Sep 9, 2019

Thanks! Yeah it looks like referencing types from api is the best solution, but for now I'll merge this since it will also work. Thanks for the PR!

@johno johno merged commit 880de38 into mdx-js:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants