Port minor fixes to the codebase from PR #61 | Part 9 #73

mdziekon · 2020-02-16T23:33:15Z

Part of #63

Changelog:

Create queue state details getter utility
Use new utility on:
- Grid Structures page
- Grid Tech page
- List Structures page
- List Tech page
Allow to schedule upgrades when queued element unlocks requirements [not part of Refactor world elements cost calculation code #61]
- List Tech page
- List Strcutures page

…age's code

(incidentally, this also allows to schedule upgrades when tech requirements are met thanks to queued elements)

…e's code

modules/development/utils/queue.utils.php

…e's code

…usage

mdziekon added 9 commits February 16, 2020 21:49

GH-63 Add new element helpers

1a15ef2

GH-63 Create queue state details getter utility

85d0569

GH-63 Use the new queue state details getter in Modern Research lab p…

afcc414

…age's code

GH-63 Parse the queue only once

3f80a5e

GH-63 Use the new queue state details getter in Legacy Research lab p…

0683e07

…age's code

GH-63 Reuse already parsed queue content

f1a7cdc

GH-63 Apply resource lock & element temp modification only once

b1e059e

(incidentally, this also allows to schedule upgrades when tech requirements are met thanks to queued elements)

GH-63 Use the new queue state details getter in Modern Structures pag…

095d977

…e's code

GH-63 Reuse already parsed queue content

4c35f38

mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Feb 16, 2020

mdziekon added this to In progress in Basic modernisation via automation Feb 16, 2020

mdziekon mentioned this pull request Feb 16, 2020

Port minor fixes to the codebase from PR #61 #63

Closed

mdziekon commented Feb 17, 2020

View reviewed changes

modules/development/utils/queue.utils.php Outdated Show resolved Hide resolved

mdziekon commented Feb 17, 2020

View reviewed changes

modules/development/utils/queue.utils.php Outdated Show resolved Hide resolved

mdziekon added 4 commits February 17, 2020 20:19

GH-63 Use the new queue state details getter in Legacy Structures pag…

2c05f9c

…e's code

GH-63 Legacy Structure page's code should correctly calculate fields …

4b9d591

…usage

GH-63 Minor Enum member rename

d755022

GH-63 Check queue type earlier to "fail fast"

0288c14

mdziekon marked this pull request as ready for review February 17, 2020 20:08

mdziekon merged commit dd69bb0 into master Feb 17, 2020

Basic modernisation automation moved this from In progress to Done Feb 17, 2020

mdziekon deleted the mdziekon/63/port-minor-modifications-part9 branch March 3, 2020 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port minor fixes to the codebase from PR #61 | Part 9 #73

Port minor fixes to the codebase from PR #61 | Part 9 #73

mdziekon commented Feb 16, 2020 •

edited

Port minor fixes to the codebase from PR #61 | Part 9 #73

Port minor fixes to the codebase from PR #61 | Part 9 #73

Conversation

mdziekon commented Feb 16, 2020 • edited

mdziekon commented Feb 16, 2020 •

edited