Refactor world elements cost calculation code #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdziekon
added
the
pr:enhancement_request
(to better emphasise that this is about calculating resources which will be taken from the planetary storages)
…s a premium resource)
…ment is not buyable
…its max upgrade level
mdziekon
added a commit
that referenced
this pull request
Feb 6, 2020
…ions-part7 Port minor fixes to the codebase from PR #61 | Part 7
…em-cost-functions
6 tasks
mdziekon
added a commit
that referenced
this pull request
Feb 9, 2020
…ions-part8 Port minor fixes to the codebase from PR #61 | Part 8
9 tasks
mdziekon
added a commit
that referenced
this pull request
Feb 17, 2020
…ions-part9 Port minor fixes to the codebase from PR #61 | Part 9
…em-cost-functions
mdziekon
force-pushed
the
mdziekon/60/worldelem-cost-functions
branch
from
d52747e
to
69a47fa
Compare
mdziekon
added a commit
that referenced
this pull request
Feb 19, 2020
…ions-part10 Port minor fixes to the codebase from PR #61 | Part 10
…em-cost-functions
mdziekon
added a commit
that referenced
this pull request
Feb 24, 2020
…ions-part11 Port minor fixes to the codebase from PR #61 | Part 11
mdziekon
added a commit
that referenced
this pull request
Feb 26, 2020
…ions-part12 Port minor fixes to the codebase from PR #61 | Part 12
mdziekon
added a commit
that referenced
this pull request
Feb 28, 2020
…ions-part13 Port minor fixes to the codebase from PR #61 | Part 13
mdziekon
added a commit
that referenced
this pull request
Mar 2, 2020
…ions-part14 Port minor fixes to the codebase from PR #61 | Part 14
mdziekon
added a commit
that referenced
this pull request
Mar 5, 2020
…ions-part15 Port minor fixes to the codebase from PR #61 | Part 15
mdziekon
added a commit
that referenced
this pull request
Mar 5, 2020
…ions-part16 Port minor fixes to the codebase from PR #61 | Part 16
mdziekon
added a commit
that referenced
this pull request
Mar 8, 2020
…ions-part17 Port minor fixes to the codebase from PR #61 | Part 16
mdziekon
added a commit
that referenced
this pull request
Mar 11, 2020
…ions-part18 Port minor fixes to the codebase from PR #61 | Part 18
mdziekon
added a commit
that referenced
this pull request
Mar 20, 2020
…ions-part19 Port minor fixes to the codebase from PR #61 | Part 19
mdziekon
commented
Mar 20, 2020
| @@ -579,6 +579,11 @@ function calculateRealResourceIncome($resourceKey, &$planet, $params) { | |||
| $resourceCurrentAmount = $planet[$resourceKey]; | |||
| $resourceMaxStorage = ($planet["{$resourceKey}_max"] * MAX_OVERFLOW); | |||
|
|
|||
| // FIXME: this should be removed as it prevents "negative income" from being | |||
mdziekon
added a commit
that referenced
this pull request
Mar 20, 2020
…ions-part20 Port minor fixes to the codebase from PR #61 | Part 20
|
Superseded by #63 and all of its related PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
Changelog: