mbed TLS client support, try 2 #48
Conversation
…th the handshake failing.
…sion added all SSL stuff between defines. In order to enable SSL add -DASYNC_TCP_SSL_ENABLED to your build flags.
… released version of arduino-esp32...
…er library is also used.
src/AsyncTCP.cpp
Outdated
| } | ||
| return ERR_BUF; // for lack of a better error value | ||
| } | ||
| return ERR_OK; |
There was a problem hiding this comment.
you are in a while loop. should continue here maybe?
|
@fremouw left a few comments. Also! Very important. You will notice that all calls to LwIP's tcp_* api are done through callbacks executed on LwIP's thread. In the ssl C code I notice that calls to LwIP are being made directly. This will cause a slew of issues and can not be merged as is. |
|
@tve thanks for taking care of rebasing this :) |
|
I'm all for examples, but there are none in this repo... Why the requirement before merging? |
|
Yup, that's where I stopped... |
|
Have you tried |
|
Hey, great stuff @tve . I used this branch to test out TLS on https://github.com/marvinroger/async-mqtt-client and works great. I am also here to offer any help needed to merge this. I have one question to ask. I am getting constantly the following message when using this PR : Besides the E, the stack behaves fine, so I am not sure why I get that. Tried to look at the code but I am not understanding what's up. Any ideas ? thanks. |
|
@tve may I have permission to push to your branch? |
|
I've been busy elsewhere, need to get back to this... If you create a PR against my repo I'd be happy to pull it in. Just create a PR in github with tve/AsyncTCP : mbed-tls-try2 as base. |
|
I was trying to push straight to this PR branch..avoiding forking your forked repo. |
|
You should not need to create a new fork, you simply select my fork & branch in the github dialog to create a PR. |
|
Is this assuming I've forked the upstream repo? What I've done thus far is: and obviously the push will fail because permissions: fwiw, changes so far are just change strlen to sizeof for pers[]. Then I could do the rebase/merge. The strlen for psk_ vars is the way it's done everywhere. |
|
Yes, I assumed you had a github account and had forked. Got a git patch? |
|
I conflated this project with another..I do have a fork under my work email on same github account. I'll have something for you. |
* Fix LoadProhibited (me-no-dev#73) * Use sizeof instead of strlen for const char[] * Add Kconfig option to control ASYNC_TCP_SSL_ENABLED * Optionally include ssl header files * Add null check for psk_ident and pskey * Do not default to PSK when root_ca is not explcitly set. tcp_ssl_new_client() has a case to handle this. * Move psk null checks to top of function, remove unneeded include, syntax cleanup. Authored-by: Bob <bob.mooij@gmail.com>
|
@me-no-dev bump |
|
What's the best way for a github noob to get this into my download of ESPAsyncWebServer and make it work in arduino code? I'm currently using a combination of AsyncWebServer and AsyncWiFiManager, is it going to be a direct file overwrite? Is there a readme on how to implement? Cheers! @tve @me-no-dev |
Adding this into platformio.ini worked for me lib_deps = |
|
is there any example to use this fork? |
|
What is the status of this, is this can be merged? |
|
What is there actually missing to merge these changes to add TLS client support? |
|
if we wait on this, it will never go through. It has been years now. There are not enough users on those platforms with the same interests! |
This is a tentative PR to replace #43 to account for the significant restructuring that was made on master since that PR.
This still only has client-side TLS support.
More testing is required before this can be considered for merging, I wanted to get this queued-up in case someone else is also working on this to avoid duplication of effort.