Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed TLS support (client) #43

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

fremouw
Copy link

@fremouw fremouw commented Apr 27, 2019

Hey,

I've added support for TLS using mbed TLS. It's only for the client side, but for most this is probably enough. You can enable it by setting the ASYNC_TCP_SSL_ENABLED build flag. Of course if anybody wants to add server side TLS support, feel free to do so.

@tve
Copy link
Contributor

tve commented Apr 28, 2019

+1, I'm using fremouw's fork.

@me-no-dev
Copy link
Owner

So, sorry :) it's been a while since I had time to spend on this. I have just added some much needed fixes to Async TCP.

Please rebase the PR to match the current code. Also, it's a bit half-ass to add just client support. Do you think that adding server is much work?

@fremouw
Copy link
Author

fremouw commented Jun 26, 2019

So, sorry :) it's been a while since I had time to spend on this. I have just added some much needed fixes to Async TCP.

Please rebase the PR to match the current code. Also, it's a bit half-ass to add just client support. Do you think that adding server is much work?

No worries! So, I totally agree with you that it would be better to also have server-side support. However, I would say that client-side TLS is used way more than server side, so from my perspective I would still go for it and merge. Btw, just noticed that @tve already rebased :-)

@me-no-dev
Copy link
Owner

please have a look at the comments I left there :) not much needed to get this into testing

@GO74
Copy link

GO74 commented Aug 5, 2019

Well, I'm currently looking for Client and Server side TLS. I would like to use it in combination with mqtt-client and I believe that it would make a lot of sense to use it in that context.

Fixed compiler warning and enable for cxx compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants