-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbed TLS support (client) #43
base: master
Are you sure you want to change the base?
Conversation
…th the handshake failing.
…sion added all SSL stuff between defines. In order to enable SSL add -DASYNC_TCP_SSL_ENABLED to your build flags.
… released version of arduino-esp32...
…er library is also used.
add support for pre-shared key TLS cipher suites
+1, I'm using fremouw's fork. |
So, sorry :) it's been a while since I had time to spend on this. I have just added some much needed fixes to Async TCP. Please rebase the PR to match the current code. Also, it's a bit half-ass to add just client support. Do you think that adding server is much work? |
No worries! So, I totally agree with you that it would be better to also have server-side support. However, I would say that client-side TLS is used way more than server side, so from my perspective I would still go for it and merge. Btw, just noticed that @tve already rebased :-) |
please have a look at the comments I left there :) not much needed to get this into testing |
Well, I'm currently looking for Client and Server side TLS. I would like to use it in combination with mqtt-client and I believe that it would make a lot of sense to use it in that context. |
Fixed compiler warning and enable for cxx compiler.
Hey,
I've added support for TLS using mbed TLS. It's only for the client side, but for most this is probably enough. You can enable it by setting the ASYNC_TCP_SSL_ENABLED build flag. Of course if anybody wants to add server side TLS support, feel free to do so.