Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970

khoih-prog · 2021-04-19T19:55:00Z

Compile error on ESP32-C3 for even simplest example simple_server

/home/kh/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp: In member function 'IPAddress AsyncWebSocketClient::remoteIP()':
/home/kh/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp:843:28: error: call of overloaded 'IPAddress(unsigned int)' is ambiguous
         return IPAddress(0U);
                            ^

Compile error on ESP32-C3 for even simplest example [simple_server](https://github.com/me-no-dev/ESPAsyncWebServer/tree/master/examples/simple_server) ``` /home/kh/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp: In member function 'IPAddress AsyncWebSocketClient::remoteIP()': /home/kh/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp:843:28: error: call of overloaded 'IPAddress(unsigned int)' is ambiguous return IPAddress(0U); ^ ```

agners · 2021-07-21T09:58:39Z

src/AsyncWebSocket.cpp

@@ -840,7 +840,7 @@ void AsyncWebSocketClient::binary(AsyncWebSocketMessageBuffer * buffer)

 IPAddress AsyncWebSocketClient::remoteIP() {
    if(!_client) {
-        return IPAddress(0U);
+        return IPAddress((uint32_t) 0);


Instead of using a type cast I'd just use a more specific type suffix:

Suggested change

return IPAddress((uint32_t) 0);

return IPAddress(0UL);

Actually, using 0UL breaks ESP32. I think the only proper way to fix this is using a static type cast.

Can we return IPADDR_ANY or IPADDR_NONE here? IPADDR_ANY looks good for this, no?

Fix deprecated functions superseded from mbed TLS v2.7.0 - mbedtls_md5_starts() - mbedtls_md5_update() - mbedtls_md5_finish() leading to following compiling error ``` /home/kh/.arduino15/packages/esp32/tools/xtensa-esp32s2-elf-gcc/gcc8_4_0-esp-2021r1/bin/../lib/gcc/xtensa-esp32s2-elf/8.4.0/../../../../xtensa-esp32s2-elf/bin/ld: libraries/ESPAsyncWebServer-master/WebAuthentication.cpp.o:(.literal._ZL6getMD5PhtPc+0x4): undefined reference to `mbedtls_md5_starts' /home/kh/.arduino15/packages/esp32/tools/xtensa-esp32s2-elf-gcc/gcc8_4_0-esp-2021r1/bin/../lib/gcc/xtensa-esp32s2-elf/8.4.0/../../../../xtensa-esp32s2-elf/bin/ld: libraries/ESPAsyncWebServer-master/WebAuthentication.cpp.o: in function `getMD5(unsigned char*, unsigned short, char*)': /home/kh/Arduino/libraries/ESPAsyncWebServer-master/src/WebAuthentication.cpp:73: undefined reference to `mbedtls_md5_starts' collect2: error: ld returned 1 exit status exit status 1 Error compiling for board ESP32S2 Dev Module. ```

### Releases v1.9.2 1. Fix MultiWiFi connection issue with ESP32 core v2.0.0-rc1+ 2. Fix AsyncWebServer library compile error with ESP32 core v2.0.0-rc1+. Check [Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970](me-no-dev/ESPAsyncWebServer#970) 3. Verify compatibility with new ESP32 core v2.0.0-rc1+ 4. Verify compatibility with new ESP8266 core v3.0.2

#### Releases v1.2.4 1. Fix library compile error with ESP32 core v2.0.0-rc1+. Check [Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970](me-no-dev/ESPAsyncWebServer#970) 2. Verify compatibility with new ESP32 core v2.0.0-rc1+

bluet · 2021-11-23T18:41:08Z

Hi wanna know if there's any update?

I'm experiencing the same issue.

Arduino: 1.8.16 (Linux), Board: "ESP32C3 Dev Module, Disabled, Default 4MB with spiffs (1.2MB APP/1.5MB SPIFFS), 160MHz (WiFi), QIO, 80MHz, 4MB (32Mb), 115200, None"

/home/bluet/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp: In member function 'IPAddress AsyncWebSocketClient::remoteIP()':
/home/bluet/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp:832:28: error: call of overloaded 'IPAddress(unsigned int)' is ambiguous
         return IPAddress(0U);
                            ^
In file included from /home/bluet/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/Arduino.h:163,
                 from /home/bluet/Arduino/libraries/ESPAsyncWebServer-master/src/AsyncWebSocket.cpp:21:
/home/bluet/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/IPAddress.h:51:5: note: candidate: 'IPAddress::IPAddress(const uint8_t*)'
     IPAddress(const uint8_t *address);
     ^~~~~~~~~
/home/bluet/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/IPAddress.h:50:5: note: candidate: 'IPAddress::IPAddress(uint32_t)'
     IPAddress(uint32_t address);
     ^~~~~~~~~
/home/bluet/.arduino15/packages/esp32/hardware/esp32/2.0.1/cores/esp32/IPAddress.h:29:7: note: candidate: 'constexpr IPAddress::IPAddress(const IPAddress&)'
 class IPAddress: public Printable
       ^~~~~~~~~
Multiple libraries were found for "WiFi.h"
 Used: /home/bluet/.arduino15/packages/esp32/hardware/esp32/2.0.1/libraries/WiFi
 Not used: /home/bluet/local/arduino-1.8.16/libraries/WiFi
exit status 1
Error compiling for board ESP32C3 Dev Module.


This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

bluet · 2021-11-23T19:07:16Z

Got it fixed by manually modify AsyncWebSocket.cpp:832,
from return IPAddress(0U); to return IPAddress((uint32_t) 0u);.

Tested on both ESP32-C3 and ESP32-S2.

FedericoBusero · 2021-12-29T16:42:13Z

This little issue breaks compilation on ESP32C3, no idea why it doesn't get merged

ndastur · 2022-05-01T16:30:30Z

This does seem like a fairly important fix. Any update or timeline please ?

maxgerhardt · 2022-05-17T11:28:44Z

People are also running in this bug when using PlatformIO and using the latest Arduino-ESP32 core here in the forums. This fix PR is valid.

MikeyMoMo · 2022-05-19T08:15:37Z

Here is is May 19, 2022 and I just had to fix this, too. Thanks to those who found it. I hope it can be fixed soon in the library for real. Been known for only 1 year.

still waiting for this PR me-no-dev#970

maxgerhardt · 2022-06-30T13:58:26Z

Yet another person running into this here.

ayushsharma82 · 2022-10-31T09:50:00Z

Somebody merge this :) It's very due and fixes the problem.

miloit · 2022-11-06T22:11:52Z

Can someone merge this?

Nailik · 2022-12-11T22:00:26Z

Issue still exists !!

ncmreynolds · 2023-01-30T18:02:03Z

Just had to fix this manually myself after encountering it, seems like a trivial merge that would fix this for a whole load of people. Any chance this can be merged?

FedericoBusero · 2023-02-12T18:52:42Z

The problem with this PR is that most of the code changes are about mbed TLS, but most of the comments and requests are about one little trivial change in one line of the code to fix the compilation error on RISC-V (ESP32-C3). Probably it is better to split the two issues.
Remark that there is another PR with only this one line of code: #1142

Adminius · 2023-12-10T20:35:29Z

run also into this issue.
return IPAddress((uint32_t)0); fixes the problem.

misery mentioned this pull request May 18, 2021

Support ESP32-C3 esphome/feature-requests#1217

Closed

agners reviewed Jul 21, 2021

View reviewed changes

khoih-prog added 2 commits August 2, 2021 14:38

Merge branch 'master' into master

7380408

khoih-prog changed the title ~~Fix compiler error for ESP32-C3~~ Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ Aug 2, 2021

khoih-prog added 2 commits August 2, 2021 21:56

Update AsyncWebSocket.h

24fc8db

Update AsyncWebSocket.h

d6322e7

Update AsyncWebSocket.h

153bb3d

mpbejo mentioned this pull request Sep 24, 2021

Compile error after upgrade to 2.0.0 WebAuthentication.cpp:73: undefined reference to `mbedtls_md5_starts espressif/arduino-esp32#5700

Closed

khoih-prog mentioned this pull request Nov 27, 2021

Example code fails compile. error: call of overloaded 'IPAddress(unsigned int)' is ambiguous khoih-prog/ESPAsync_WiFiManager_Lite#2

Closed

justind000 mentioned this pull request Apr 14, 2022

Compile error for ESP32C3 Hieromon/AutoConnect#480

Closed

IronBamBam1990 mentioned this pull request May 8, 2022

WebAuthentication.cpp:73: undefined reference to `mbedtls_md5_starts' #1147

Open

Merge branch 'me-no-dev:master' into master

8e9c5a6

vortigont added a commit to vortigont/ESPAsyncWebServer that referenced this pull request May 28, 2022

src/AsyncWebSocket.cpp fix build error for esp32-c3

209152a

still waiting for this PR me-no-dev#970

bluet mentioned this pull request Feb 12, 2023

Update AsyncWebSocket.cpp #1142

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970

Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970

khoih-prog commented Apr 19, 2021

agners Jul 21, 2021 •

edited

agners Jul 22, 2021

vladkozlov69 Dec 14, 2021

bluet commented Nov 23, 2021

bluet commented Nov 23, 2021 •

edited

FedericoBusero commented Dec 29, 2021

ndastur commented May 1, 2022

maxgerhardt commented May 17, 2022 •

edited

MikeyMoMo commented May 19, 2022

maxgerhardt commented Jun 30, 2022

ayushsharma82 commented Oct 31, 2022

miloit commented Nov 6, 2022

Nailik commented Dec 11, 2022

ncmreynolds commented Jan 30, 2023

FedericoBusero commented Feb 12, 2023

Adminius commented Dec 10, 2023

Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970

Are you sure you want to change the base?

Fix compiler error for ESP32-C3 and mbed TLS v2.7.0+ #970

Conversation

khoih-prog commented Apr 19, 2021

agners Jul 21, 2021 • edited

Choose a reason for hiding this comment

agners Jul 22, 2021

Choose a reason for hiding this comment

vladkozlov69 Dec 14, 2021

Choose a reason for hiding this comment

bluet commented Nov 23, 2021

bluet commented Nov 23, 2021 • edited

FedericoBusero commented Dec 29, 2021

ndastur commented May 1, 2022

maxgerhardt commented May 17, 2022 • edited

MikeyMoMo commented May 19, 2022

maxgerhardt commented Jun 30, 2022

ayushsharma82 commented Oct 31, 2022

miloit commented Nov 6, 2022

Nailik commented Dec 11, 2022

ncmreynolds commented Jan 30, 2023

FedericoBusero commented Feb 12, 2023

Adminius commented Dec 10, 2023

agners Jul 21, 2021 •

edited

bluet commented Nov 23, 2021 •

edited

maxgerhardt commented May 17, 2022 •

edited