small refactor of supported html dice logic

meadsteve · Apr 2, 2018 · 4614c02 · 4614c02
1 parent 451bc5c
commit 4614c02
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Renderer/Html.php b/src/Renderer/Html.php
@@ -6,6 +6,8 @@
 
 class Html implements DiceRenderer
 {
+    const SUPPORTED_DICE = ["d6", "d20"];
+
     private $urlRoot;
 
     public function __construct($urlRoot)
@@ -35,8 +37,9 @@ public function urlPrefix(): string
     public function htmlForSingleDice(Dice $dice)
     {
         $name = $dice->name();
-        if ($name != "d6" && $name != "d20") {
-            throw new UnrenderableDiceException("Currently only d6 and d20 can be rendered as html");
+        if (!in_array($name, self::SUPPORTED_DICE)) {
+            $supportedDice = implode(", ", self::SUPPORTED_DICE);
+            throw new UnrenderableDiceException("Only the following can be rendered as html: $supportedDice");
         }
         $roll = $dice->roll();
         $url = "{$this->urlRoot}/images/poorly-drawn/{$name}/{$roll}.png";