Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add recipekeeper migration #3642

Merged
merged 2 commits into from
May 31, 2024

Conversation

derpferd
Copy link
Contributor

@derpferd derpferd commented May 24, 2024

What type of PR is this?

  • documentation
  • feature

What this PR does / why we need it:

  • Adds support for Recipe Keeper migration

Which issue(s) this PR fixes:

Fixes the discussion #3331

Special notes for your reviewer:

Borrowed code layout, style, & format from Plan to Eat migration implementation #2635.

Testing

  • Added a unit test for Recipe Keeper, including blank fields and multiple tags.
  • Tested a full migration using my personal recipe export.
Screenshot 2024-05-23 at 8 40 45 PM Screenshot 2024-05-23 at 8 40 10 PM Screenshot 2024-05-23 at 8 38 23 PM

@boc-the-git boc-the-git changed the title Added recipekeeper migration. Fixes #3331 feat: Add recipekeeper migration May 31, 2024
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR 🎉

@boc-the-git boc-the-git enabled auto-merge (squash) May 31, 2024 09:51
@boc-the-git boc-the-git merged commit f4f2b86 into mealie-recipes:mealie-next May 31, 2024
10 checks passed
@ryanwise
Copy link

ryanwise commented Jun 5, 2024

trying to import 20 recipes from recipe keeper and there seems to be a file error when running the migration:

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkenbp2_o/recipekeeperhtml/recipes.html'

I'm brand new to Mealie, so I don't know if this is a larger migrations issue or specific to recipe keeper. any ideas?

@boc-the-git
Copy link
Collaborator

@ryanwise can you please report a bug, filling in all the required info? https://github.com/mealie-recipes/mealie/issues/new?assignees=&labels=bug%2Ctriage&projects=&template=bug-report.yaml&title=%5BBUG%5D+-+YOUR+DESCRIPTIVE+TITLE+GOES+HERE

It would also be good to attach your backup file there.

This pull request won't be actively monitored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants