[encoding] Use encoding dialog for the first pass (no re-use yet) #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch falls way short of the goal to use the single instance of the encoding dialog for both the first and the second pass. It just replaces the working dialog with the encoding one for the first pass with related additional tweaks like disabling the "Advanced" tab and making information about remaining time available. The benefit: it is now possible to minimize Avidemux to the notification area during the first pass too (see reference). Without re-use of the dialog instance, the application window will pop up after the first pass though.
The patch makes also the "Pass 1" translatable and hides the disfunctional shutdown checkbox and priority combo – on Linux and Mac completely, on Windows only for the first pass. The name of the priority label is changed to clarify its purpose when used in code elsewhere.
Automatic shutdown after encoding can't work now, of course, as the value of
shutdownRequired
is not evaluated in the destructor andADM_shutdown
is never called. IMVHO, this functionality should be either fixed or the checkbox removed / hidden to avoid user confusion.