Skip to content
This repository has been archived by the owner on May 26, 2018. It is now read-only.

Min-Vid player is not closed and the "X" button is not working, if the add-on is removed #970

Closed
SoftVision-CosminMuntean opened this issue Aug 10, 2017 · 3 comments · Fixed by #987
Closed

Min-Vid player is not closed and the "X" button is not working, if the add-on is removed #970

SoftVision-CosminMuntean opened this issue Aug 10, 2017 · 3 comments · Fixed by #987
Labels
[QA]:Verified Fixed Label for QA to mark verified fixed issues
Milestone
Micro webextensio...

Comments

@SoftVision-CosminMuntean
Copy link
Collaborator

[Affected versions]:

  • Firefox 55.0 and up
  • Min-Vid 1.0.10

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Latest Min-Vid add-on (1.0.10) was previously installed on a clean profile.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to one of the supported platforms (e.g www.youtube.com).
  2. Send a video video to the Min Vid player.
  3. Open a new tab and go to about:addons -> Extensions page.
  4. Remove the Min-Vid add-on.
  5. Observe the Min-Vid player.

[Expected result]:

  • The add-on is removed and the Min-Vid player is closed.

[Actual result]:

  • The add-on is removed, but the Min-Vid player remains opened and the the "X" button is not working.

[Notes]:

  • Attaching a screen recording of the issue:
    min vid removed
@SoftVision-CosminMuntean SoftVision-CosminMuntean added this to the replace-sdk milestone Aug 10, 2017
@meandavejustice
Copy link
Owner

Listen for the uninstall event and close the window in this case

@meandavejustice
Copy link
Owner

https://github.com/mozilla-services/screenshots/blob/master/addon/bootstrap.js#L136

meandavejustice pushed a commit that referenced this issue Aug 15, 2017
Close window on addon removal
e1d837c 
- fixes #970
@meandavejustice meandavejustice mentioned this issue Aug 15, 2017
Merged
meandavejustice pushed a commit that referenced this issue Aug 17, 2017
Close window on addon removal (#987)
38e679a 
* Fix links in changelog (#977)

* Update non breaking dependencies (#985)

- addons-linter
- eslint-plugin-mozilla
- eslint-plugin-react
- husky
- react-player
- webpack

Also needed to add a new dep:
- eslint-no-unsanitized

Looks like this is a dep of eslint-plugin-mozilla that isn't listed correctly in the
eslint-plugin-mozilla package. This package is for some reason bundled in with gecko
so I do not have the time to contribute a fix at this time. Hopefully I will find
the time later.

* Close window on addon removal

- fixes #970
@SoftVision-CiprianMuresan
Copy link
Collaborator

The issue is no longer reproducible on the latest version of Min-Vid built on 8/18/2017. Marking as verified.

@SoftVision-CiprianMuresan SoftVision-CiprianMuresan added the [QA]:Verified Fixed Label for QA to mark verified fixed issues label Aug 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
[QA]:Verified Fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
Micro webextension follow up
Development

Successfully merging a pull request may close this issue.

Close window on addon removal meandavejustice/min-vid
3 participants
@meandavejustice @SoftVision-CiprianMuresan @SoftVision-CosminMuntean