This repository has been archived by the owner on May 26, 2018. It is now read-only.
Close window on addon removal #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
meandavejustice
commented
Aug 15, 2017
meandavejustice
commented
- fixes Min-Vid player is not closed and the "X" button is not working, if the add-on is removed #970
- addons-linter - eslint-plugin-mozilla - eslint-plugin-react - husky - react-player - webpack Also needed to add a new dep: - eslint-no-unsanitized Looks like this is a dep of eslint-plugin-mozilla that isn't listed correctly in the eslint-plugin-mozilla package. This package is for some reason bundled in with gecko so I do not have the time to contribute a fix at this time. Hopefully I will find the time later.
- fixes #970
meandavejustice
force-pushed
the
master
branch
from
a23176b
to
bbd56c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.