Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix deprecated $http.error() and $http.success() #1479

Closed
simison opened this issue Sep 5, 2016 · 3 comments
Closed

Fix deprecated $http.error() and $http.success() #1479

simison opened this issue Sep 5, 2016 · 3 comments
Assignees
@mleanos
Labels
platform:angular
Milestone
0.5.0

Comments

@simison
Copy link
Member

simison commented Sep 5, 2016 •
edited
Loading

https://docs.angularjs.org/api/ng/service/$http

The $http legacy promise methods success and error have been deprecated. Use the standard then method instead. If $httpProvider.useLegacyPromiseExtensions is set to false then these methods will throw $http/legacy error.

Used at least here:
@simison
Copy link
Member Author

simison commented Sep 5, 2016

Happy if someone else would have the time to do a PR. :P

@simison simison mentioned this issue Sep 5, 2016
Closed
@mleanos
Copy link
Member

mleanos commented Sep 5, 2016

I'm on it! This has been in the back of my mind for a while. Thanks Mikael.

@simison
Copy link
Member Author

simison commented Sep 5, 2016 •
edited
Loading

@mleanos Thanks! You might wanna have a look at this:

@lirantal lirantal added this to the 0.5.0 milestone Sep 5, 2016
mleanos added a commit to mleanos/mean that referenced this issue Sep 15, 2016
@mleanos
Deprecated $http success/error promise methods
af709db 
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes meanjs#1479
@mleanos mleanos mentioned this issue Sep 15, 2016
Merged
mleanos added a commit that referenced this issue Sep 17, 2016
@mleanos
Deprecated $http success/error promise methods (#1508)
fa13804 
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479
hyperreality pushed a commit to hyperreality/mean that referenced this issue Sep 17, 2016
@mleanos @hyperreality
Deprecated $http success/error promise methods (meanjs#1508)
5b99455 
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes meanjs#1479
Wuntenn pushed a commit to Wuntenn/mean that referenced this issue Sep 20, 2016
@mleanos
Deprecated $http success/error promise methods (meanjs#1508)
eb8c36e 
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes meanjs#1479
mleanos pushed a commit that referenced this issue Oct 5, 2016
@hyperreality @mleanos
feat(core): Minor UI fixes for mobile; autofocus (#1499)
73a7c2c 
* Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.

* switched to handlebar template for passing the server's owasp config down to the client.

reverted some of the other changes (regarding the http request).

* Removed debug code.

* Changed variable name to owaspConfig

* Fixed minor type-o's and set owasp.config() rather than the underlying configs.

* chore(tidy): tidying up minor lint and layout issues

* fix(lint): CSS alphabetize warnings (#1498)

Fixes css lintings warnings of properties not alphabetized.

* fix(authentication) Stops error on signin/signup (#1495)

Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.

* Moved owasp config into default and reverted other config files.

Modified config to be "shared". This will allow future configurations to be easily passed to the client.

* fixed 403 redirect if not signed in (#1496)

* Update form-article.client.view.html

For New Article, delete function no required

* UI changes for mobile; autofocus

* fixed broken password popover balloon

* add e2e test for autofocus

* Remove test, fix delete social login button

* feat(core): Move template to .github folder

* Deprecated $http success/error promise methods (#1508)

Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479

* rebase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mleanos mleanos

Labels
platform:angular
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@simison @lirantal @mleanos