deprecate(grunt): Remove Grunt #1175

codydaig · 2016-01-30T20:04:51Z

This PR serves as the PR to remove grunt, but also as the discussion of what needs to be accomplished before this can get merged in. Is there any functionality still in grunt that is not in gulp? I will add todo items left in comments to this description.

Tasks still to be added to Gulp:

grunt coverage feat(tests): Add client and server test coverage to Gulp #1466
copy:localConfig feat(gulp): Add the copy:localConfig task to Gulp #1191
mkdir:upload
ngAnnotate
mongoose (unnecessary)
node-inspector

trendzetter · 2016-01-30T23:38:28Z

Isn't it a pity to remove perfectly working code (as far as I used it) while it's replacements have still issues producing a production build?
#1160

Wouldn't it be sufficient for the time being to add a notice that this code is no longer maintained?

codydaig · 2016-01-31T00:11:21Z

@trendzetter It prevents the framework from getting bloated. Templatecache is not in grunt, it's only in gulp. We've been adding things to gulp lately in favor or grunt. Grunt is still in the 0.4 releases.

mg1075 · 2016-01-31T03:31:19Z

Agree with @trendzetter; I would vote for continued grunt support.

I don't see where gulp covers the copy:localConfig task.

mean/gruntfile.js

Lines 218 to 226 in e140880

    
           copy: { 
        
             localConfig: { 
        
               src: 'config/env/local.example.js', 
        
               dest: 'config/env/local.js', 
        
               filter: function () { 
        
                 return !fs.existsSync('config/env/local.js'); 
        
               } 
        
             } 
        
           }

mleanos · 2016-01-31T04:30:25Z

There's a bit more work to do to get Gulp in line with the tasks that exist in our Grunt implementation. This PR is a great starting point to get that conversation going, as Cody said.

Look at all the dependencies we get to remove, when we get rid of Grunt. The more dependencies this framework has, the more likely we'll run into issues with environmental compatibilities. Ive run into quite a bit of issues with Grunt. Not really at all with Gulp.

Again, like Cody said, the 0.4 releases will have Grunt. Even if someone were to install, or upgrade to 0.5.x, they would be able to add Grunt very easily. It would be a matter of a few copy & pastes.

@codydaig I'll help out with getting Gulp ready for this to be merged. I know the tasks pretty well, between the two.

ilanbiala · 2016-01-31T18:50:00Z

@codydaig @mleanos I'll help out with the review.

trendzetter · 2016-01-31T21:37:26Z

@codydaig I am very much in favor of lean and mean. I also value continuity and stability as a user of the framework. It appeared to me that when tracking the upstream I could run into issues with producing occasional production builds.

ilanbiala · 2016-01-31T21:55:02Z

@trendzetter what issues have you had with Gulp?

trendzetter · 2016-02-01T12:00:48Z

I am just referring to #1160
The production build produced by gulp is not usable if I understand correctly. A solution is in the making but not finished.
So far I have been using the grunt scripts to run my project, very recently I started running gulp for development. I can give the production build a try tonight to establish if it breaks currently working functionality or if it only affects "new things".

ilanbiala · 2016-02-01T13:41:25Z

@trendzetter that is something that doesn't even exist in our Grunt setup, so that is not an issue really. Please try Gulp and let us know what else needs to be added to allow us to switch over from Grunt to Gulp.

trendzetter · 2016-02-01T14:43:37Z

I not sure what you mean by "that doesn't even exist in our Grunt setup".
If I run "grunt build" I get a set of minimized files which I use for setting up a demoserver (in preparations of the real production when the application goes live).
I admit I have no clue about buildtools. I will look into what you are saying tonight.

ilanbiala · 2016-02-01T15:44:18Z

@trendzetter nothing in Grunt creates a template cache for Angular in the same way that Gulp does. What you are referring to is minification, which both build tools already do.

trendzetter · 2016-02-01T20:11:52Z

@ilanbiala Sorry for my ignorance. I just tried the minification build and they both run the same at first sight although the grunt dist files are 1kb smaller.

trainerbill · 2016-02-04T16:38:27Z

Thoughts on using:

https://www.npmjs.com/package/gulp-strip-debug

Would be nice to have some debug statements in the code base. Like on controller instatiation do

console.log('ArticlesController::Init', vm);

Then let gulp strip them on production/test build. Obviously we wouldn't allow all console.logs in PR's, but having strategic ones would save a bunch of time IMO

Thoughts?

ilanbiala · 2016-02-04T18:15:59Z

@trainerbill I don't think we have that in Grunt, so that should be in a different issue. This issue is just about getting everything in Grunt into Gulp so we can strip Grunt out.

mleanos · 2016-02-06T22:17:31Z

@codydaig The following tasks can be added to the list

mkdir:upload
ngAnnotate - The Build task uses this

Not sure if we need these. Does anyone have any insight?
3) mongoose
4) node-inspector

codydaig · 2016-02-10T00:12:00Z

thanks @mleanos

rhutchison · 2016-02-10T08:13:10Z

@mleanos where are we using ngAnnotate?

simison · 2016-08-30T15:08:10Z

package.json

@@ -16,7 +16,7 @@
  },
  "scripts": {


Scripts were already taken care of: 5a91d7d

Yeah I'm gonna close this PR in favor of a new one. Some things have changed.

mleanos · 2016-08-30T19:55:33Z

I'm fine with removing Grunt officially. I had reservations on supporting users that rely on Grunt already. However, as someone pointed out earlier, anyone can look back at previous versions of the framework to see how to integrate Grunt.

mleanos · 2016-09-08T19:44:13Z

I think we can merge this in, after the conflicts are resolved (re-base). Everything but the ngAnnotate has been added to Gulp. Although, we do include the Gulp plugin for ngAnnotate since it's being used in the minification of the js files. But we don't need a Gulp task dedicated to ngAnnotate.

mleanos · 2016-10-02T21:52:16Z

@codydaig Would you like to wrap this one up? It looks like this is the last key issue before we're ready to release 0.5.0.

codydaig · 2016-10-04T20:02:32Z

@mleanos Rebased.

coveralls · 2016-10-04T20:31:49Z