This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(gulp): Add the copy:localConfig task to Gulp #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
6 tasks
|
Should copy:localConfig task come before lint? also, I don't think you want to run copy:localConfig in parallel with nodemon/watch? do you? |
| @@ -202,6 +203,21 @@ gulp.task('imagemin', function () { | |||
| .pipe(gulp.dest('public/dist/img')); | |||
| }); | |||
|
|
|||
| // Copy local development environment config | |||
| gulp.task('copy:localConfig', function () { | |||
There was a problem hiding this comment.
The colon syntax is a remnant from Grunt, and I'd rather it not come over to Gulp as I think it's unclear. Can we try to rename these so they make sense? How about copyLocalConfig?
mleanos
force-pushed
the
gulp-copy-localConfig
branch
from
c4b5cb2
to
1465ee1
Compare
|
@rhutchison I've updated this based on your feedback. Thanks. Also, @ilanbiala I've renamed the Gulp task to "copyLocalEnvConfigExample". WDYT? Let me know how it looks to you now. |
|
That's pretty long, can you make it shorter like |
Adds a task to copy the example local environment config example, and save it as a development environment config. Renamed the task for Gulp from copy:localConfig (Grunt naming convention) to copyLocalEnvConfigExample. Releated meanjs#1175
mleanos
force-pushed
the
gulp-copy-localConfig
branch
from
1465ee1
to
b0f76dc
Compare
|
@ilanbiala Updated the name. Thanks. |
ilanbiala
added a commit
that referenced
this pull request
Feb 11, 2016
feat(gulp): Add Grunt's copy:localConfig task to Gulp
This was referenced Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a task to copy the example local environment config, and save it as a development environment config.
Releated: #1175