Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Docker development environment update and packages cleanup #1603

Merged
merged 1 commit into from
Oct 30, 2016

Conversation

lirantal
Copy link
Member

@lirantal lirantal commented Oct 28, 2016

  • Cleaning up apt packages result in a much smaller docker image
  • Updating to support Node v6
  • Enabling npm install for development environment for quickly refreshing the container without building

Copy link
Member

@mleanos mleanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should wait to see if this helps with @helxsz issue.

@mleanos
Copy link
Member

mleanos commented Oct 29, 2016

On second thought, I don't think we need to wait for @helxsz to report back. These changes accomplish the goal of cleaning up the Docker image and having the development configuration install the packages & start the application will really help out during development.

I say merge when you're ready.

@lirantal
Copy link
Member Author

Cool, merging in.
I'm working with these changes locally and haven't seen any issues yet.

@lirantal lirantal merged commit e62b680 into meanjs:master Oct 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants