Docker development environment update and packages cleanup #1603

Merged
merged 1 commit into from Oct 30, 2016

Projects

None yet

2 participants

@lirantal
Member
lirantal commented Oct 28, 2016 edited
  • Cleaning up apt packages result in a much smaller docker image
  • Updating to support Node v6
  • Enabling npm install for development environment for quickly refreshing the container without building
@lirantal lirantal feat(docker): cleaning up pkgs and enabling npm install for dev env
f072cd6
@lirantal lirantal added this to the 0.6.0 milestone Oct 28, 2016
@lirantal lirantal self-assigned this Oct 28, 2016
@mleanos

LGTM. We should wait to see if this helps with @helxsz issue.

@mleanos
Member
mleanos commented Oct 29, 2016

On second thought, I don't think we need to wait for @helxsz to report back. These changes accomplish the goal of cleaning up the Docker image and having the development configuration install the packages & start the application will really help out during development.

I say merge when you're ready.

@lirantal
Member

Cool, merging in.
I'm working with these changes locally and haven't seen any issues yet.

@lirantal lirantal merged commit e62b680 into meanjs:master Oct 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.735%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment