This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Adding another job for Travis CI to run the grunt coverage task on every build
#886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lirantal why not have coverage run at the end of the tests? What's better about this way? |
|
I don't know. Do you care to see the code coverage everytime you run tests? I didn't think it was related. Having distinct tasks for each, just like we separated the whole tests into test:server and test:client seems to make more sense. |
|
I'll second @lirantal. I don't want to see the coverage report every time I run tests on the project. |
|
@lirantal ok, I agree with you on that. LGTM. |
|
Cool, let's see if we get code coverage reports now on coveralls |
lirantal
added a commit
that referenced
this pull request
Sep 4, 2015
…ge-task Adding another job for Travis CI to run the `grunt coverage` task on every build
|
Yep, awesome! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the code coverage running as part of our CI in #811