This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
connect: start fixing IPv6 addresses #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* connect_impl: fix treatment of IPv6 addresses I believe, this diff alone should be enough to fix the issue reported in measurement-kit/ooniprobe-ios#61. I have noticed that also from my home (where there is no IPv6 connectivity) the code fails because it cannot even parse such addresses. With this diff applied, instead, it fails because of a `host_unreachable` error, which makes more sense to me (of course, to see the real error, all of #1098 is required). * connect: document scoped link-local IPv6 addrs bug I was temped to fix this as part of this pull request but then noticed it would have taken a bit of refactoring that instead I would like to perform separately. * connect: add warnings for each error case We can (and will) do better by mapping errors, but, for now, let's start by adding basic warning messages that end up in logs.
bassosimone
force-pushed
the
fix/connect_ipv6
branch
from
d8a742a
to
d8e721c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe, this diff alone should be enough to fix the issue
reported in measurement-kit/ooniprobe-ios#61.
I have noticed that also from my home (where there is no IPv6
connectivity) the code fails because it cannot even parse such
addresses. With this diff applied, instead, it fails because
of a
host_unreachableerror, which makes more sense to me (ofcourse, to see the real error, all of #1098 is required).
I was temped to fix this as part of this pull request but then
noticed it would have taken a bit of refactoring that instead I
would like to perform separately.
We can (and will) do better by mapping errors, but, for now, let's
start by adding basic warning messages that end up in logs.