This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
async: adjust tests to expose bug, then fix it #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change, this diff is needed to prepare for the following diff that will trigger a crash in async.cpp.
This diff is best reviewed using `git diff -w` feature.
On MacOS, you see something like the following:
$ ./test/common/async
...
test #1: http: BODY
test #1: http: received body chunk...
test #1: http: END
test #1: http: we have reached end of response
test #1: net_test: tearing down
test #1: net_test: written entry
test #1: net_test: reached end of input
async: test stopped
test complete: 140525600582144
async: bottom of loop thread
async: loop thread locked
async: empty
async: thread stopped
all tests completed
do another iteration of tests
test created: 140525592131072
async: test inserted
async: background thread started
libc++abi.dylib: async: loop thread entered
terminating
Abort trap: 6
A similar error is seen on GNU/Linux.
With this fix committed, the code does not crash anymore when we create another background thread. Since I observed this both on MacOS and Linux with different compilers and C++ libraries, it was probably a programmer error that I not explicitly joined/detached the thread. Debugging this issue I also noticed memory leaks on Linux that I am going to investigate.
bassosimone
changed the title
|
Smells like hotfix spirit. I think we can merge this safely. |
hellais
added a commit
that referenced
this pull request
Jun 19, 2015
async: adjust tests to expose bug, then fix it
|
"I found it hard; it's hard to find" 👍 |
|
Oh well, whatever, nevermind |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjusts async tests to expose a bug (leading to a crash) spotted while working on the iOS application and then fixes the bug (basically, the issue was that I overwrote the thread object before either detaching or joining it).