Add support for BarcodeDetector and refactors around it #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs
- [ ] Check support / performance on Android / IOS device
- [ ] Add additional documentation (Github / article) for experimental features
- [ ] Link this to readme
- [ ] Update demo page
Notes:
- On Chrome `ZXing` based decoder takes `20-25` ms on my Mac book pro 16.
- On Chrome `BarcodeDetector` based decoder takes `8.6-11 ms` on my Mac book pro 16.
Fix added for Safari. Also, fixed some Codacy styling issues on readme
|
Using native library has clear performance benefits but the support is not good yet.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
Notes:
ZXingbased decoder takes20-25ms on my Mac book pro 16.BarcodeDetectorbased decoder takes8.6-11 mson my Mac book pro 16.closes #195