Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency between viewfinder qrbox and actual feed in canvas #28

Merged
merged 2 commits into from
May 1, 2020

Conversation

mebjas
Copy link
Owner

@mebjas mebjas commented May 1, 2020

  • Fixed the video size issue in issues/21
  • Removed fixed height of viewfinder, now the height is based on the video stream. The width is honored if the input element has a default width. Otherwise default width is applied.
  • If config.qrbox is greater than derived height, the config is ignored & no shading is applied.
  • The sequence of steps have changed
    • First we get the video feed from the selected camera
    • Then we render video
    • Then based on the height of the video we set the canvas and start scanning.
  • For file scanning, if the container element has some height or width both are honored.
    Otherwise default width is applied and height is derived from the image.

@mebjas
Copy link
Owner Author

mebjas commented May 1, 2020

Screenshot 2020-05-01 at 4 44 33 PM

This should fix the inconsistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant