Skip to content

Commit

Permalink
Add back cython to INSTALL_REQUIRES.
Browse files Browse the repository at this point in the history
  • Loading branch information
@moorepants
moorepants committed Jul 21, 2023
1 parent 3aa661a commit 5088cfc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
EMAIL = "moorepants@gmail.com"
URL = "https://github.com/mechmotum/cyipopt"
INSTALL_REQUIRES = [
"cython >= 0.26,<3",
"numpy>=1.15",
"setuptools>=39.0",
]
Expand Down

3 comments on commit 5088cfc

@musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented on 5088cfc Jul 21, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did I overlook when I removed this in 236dbe1? I couldn’t find anywhere that Cython (or setuptools, actually) was imported outside of setup.py.

@moorepants
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython is required to install the package from source with python setup.py install. It is in INSTALL_REQUIRES because historically it was needed to give some kind of check that build reqs were present. When we move away from setup.py in the future, these things can be changed.

@musicinmybrain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython is required to install the package from source with python setup.py install. It is in INSTALL_REQUIRES because historically it was needed to give some kind of check that build reqs were present. When we move away from setup.py in the future, these things can be changed.

Ok, thanks for the explanation!

Please sign in to comment.