Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_serializing_if support for attributes #108

Merged
merged 2 commits into from May 31, 2021
Merged

Add skip_serializing_if support for attributes #108

merged 2 commits into from May 31, 2021

Conversation

olvyko
Copy link
Contributor

@olvyko olvyko commented Apr 29, 2021

Before that change skip_serializing_if won't work for struct fields that marked as attribute.
I changed ser_wrap_default_attribute func and added test for that change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 273

  • 17 of 24 (70.83%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 59.895%

Changes Missing Coverage Covered Lines Changed/Added Lines %
yaserde_derive/src/lib.rs 0 2 0.0%
yaserde_derive/src/common/field.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
yaserde_derive/src/common/field.rs 1 0%
Totals Coverage Status
Change from base Build 272: 0.3%
Covered Lines: 1141
Relevant Lines: 1905

💛 - Coveralls

@enfipy
Copy link

enfipy commented May 8, 2021

Any news on this?

@MarcAntoine-Arnaud MarcAntoine-Arnaud merged commit 29261a3 into media-io:master May 31, 2021
@enfipy
Copy link

enfipy commented May 31, 2021

@MarcAntoine-Arnaud Thanks! Can you also publish a new version? It will help us publish android-manifest to crates.

@MarcAntoine-Arnaud
Copy link
Contributor

Done with the 0.7.0, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants