Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed stuck double tap #640

Merged
merged 2 commits into from
May 30, 2024

Conversation

abdelaziz-mahdy
Copy link
Member

Issue Description

  • Problem: The seek buttons in the video controls were incorrectly remaining hidden while still registering clicks.
  • Cause: This behavior was due to both _hideSeekForwardButton and _mountSeekForwardButton being set to true at the same time. The root cause of this issue was traced back to the TweenAnimationBuilder's end value being set to zero which prevents onend from being called.

Proposed Solution

  • Fix Implementation: The proposed fix involves a minor yet critical adjustment to the TweenAnimationBuilder.
  • Details:
    • Change the end value from 0.0 to a minimal non-zero value (0.000001).
    • This adjustment allows the 'on end' callback to be called to hide and unmount the UI elements.

@abdelaziz-mahdy
Copy link
Member Author

used animated opacity and timers instead, since the bug still happens and not nothing resets it. :(

abdelaziz-mahdy added a commit that referenced this pull request May 30, 2024
@abdelaziz-mahdy abdelaziz-mahdy merged commit 6aa0c2c into media-kit:main May 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant