-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined Fixes from PR #644, #640, and #618 #647
Combined Fixes from PR #644, #640, and #618 #647
Conversation
…into fixes-comibned
…o357/media_kit into fixes-combined
…o357/media_kit into fixes-combined
…ia_kit into fixes-combined
…o357/media_kit into fixes-combined
Great update, it happens to be related to double-clicking. Can I take the liberty of asking a question? I want to customize the double-click function and use double-click to pause playback. Can I only modify the source code? |
sadly for this you will need to implement your own controls |
thank you for your reply,this is a good idea |
…ding-another-fix
…rtist/media-kit into adding-another-fix
since i am using this branch on my own app i added the tap to pause and play using the #742 which is showing in the commits and the padding under |
media_kit_video/lib/media_kit_video_controls/src/controls/material.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request combines changes from several individual pull requests to avoid merge conflicts. The included pull requests are as follows:
feel free to merge this incase all is good
summary
Overview:
This pull request introduces a series of enhancements and bug fixes to the video player controls, improving the overall user experience and responsiveness. Key areas of focus include widget width handling, gesture detection, and the double-tap seek UI, along with a new feature for mouse visibility control.
Fixes and Enhancements:
Widget Width Handling Issue:
Gesture Detection Delay:
Double Tap Seek UI Adjustment:
Seek Button Visibility Issue:
New Feature:
hideMouseOnControlsRemoval
property inMaterialDesktopVideoControlsThemeData
.Usage Example:
This pull request collectively addresses various aspects of video player control usability, enhancing both the aesthetic and functional experience for end-users.