Remove dependency on multihashing module #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the synchronous
multihashing
module is no longer recommended, this removes our dependency on it.We're were using it in the
b58MultihashForBuffer
helper (andDatastore.put
which was written before the helper and can use it instead).We are calling that helper in a couple of sync methods (like the constructor for
ExpandedSimpleStatementBody
), so I did the lazy thing and just did a synchronous implementation using node'scrypto.createHash
instead of trying to make everything async so we can use https://github.com/multiformats/js-multihashing-async which usescrypto.createHash
on node anyway.