Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on multihashing module #181

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Conversation

yusefnapora
Copy link
Contributor

Since the synchronous multihashing module is no longer recommended, this removes our dependency on it.

We're were using it in the b58MultihashForBuffer helper (and Datastore.put which was written before the helper and can use it instead).

We are calling that helper in a couple of sync methods (like the constructor for ExpandedSimpleStatementBody), so I did the lazy thing and just did a synchronous implementation using node's crypto.createHash instead of trying to make everything async so we can use https://github.com/multiformats/js-multihashing-async which uses crypto.createHash on node anyway.

Copy link
Contributor

@parkan parkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yusefnapora yusefnapora merged commit 83e169e into master Feb 9, 2017
@yusefnapora yusefnapora deleted the yn-rm-multihashing branch February 9, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants