1.0.6 - Support older version of BetterReflection #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 16, 2018 09:05
* 'master' of github.com:mediact/dependency-guard: Be more specific on when the class in the catch is autoloaded
Version 3 of BetterReflection requires PHP parser 4, which in turn is also required by PHPStan. PHPStan has a dependency on Symfony Console, which supports 3 | 4 in more recent versions, and goes back to 2 in older versions, which in turn force PHP parser 3 and thus becomes incompatible with the newer version of BetterReflection. With the new changes, Magento 2 projects and modules can be statically analyzed by DependencyGuard.
janmartenjongerius
added
bug
arnoudhgz
approved these changes
Nov 14, 2018
janmartenjongerius
requested review from
michielfb
and removed request for
ksangers
michielfb
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3 of BetterReflection requires PHP parser 4, which in turn is
also required by PHPStan. PHPStan has a dependency on Symfony Console,
which supports 3 | 4 in more recent versions, and goes back to 2 in
older versions, which in turn force PHP parser 3 and thus becomes
incompatible with the newer version of BetterReflection.
With the new changes, Magento 2 projects and modules can be statically
analyzed by DependencyGuard.