[Accessibility] Make the progress bar keyboard and screen reader accessible #635 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror by ensuring the media player's auto-generated container id is unique to the document.
…e an anchor element for discoverability (READ: USE SEMANTIC MARKUP) and added in keyboard support. Gave the anchor the appropiate ARIA attributes and ROLE property for screen readers. Also added a CSS class for offscreen text. Used this to add some offscreen text to discribe how to use the keyboard to seek the current video.
…into accessibility
…, trukish, arabic, italian and portuguese.
…, trukish, arabic, italian and portuguese.
…ccessibility Conflicts: build/mediaelement-and-player.js build/mediaelement-and-player.min.js build/mediaelement.js build/mediaelement.min.js build/mediaelementplayer.js build/mediaelementplayer.min.js src/js/me-namespace.js
…t for labels added. Added Home/End support to jump to the begining/end of the video. Changed the up & down behaviour to be skip by 10% of the time instead of 10 seconds. Added support for restarting the player when on the slider control (space+enter) Made the video player respect its current state (if paused when started stays paused, if playing playing restarts)
…so that screen readers will have some context of the application they are hitting. From my testing NVDA would not read ARIA-LABEL's when something has role=application.
Conflicts: src/js/me-i18n-locale-en.js src/js/mep-feature-progress.js
|
I am going to close this pull request for now as we have found a couple cases where screen readers are not behaving as we would like. I will resubmit once we have a fix for those cases, which should hopefully allow us to also include our work on Captions and subtitles as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests addresses mediaelementjs accessibility concerns (Issue #635) :
Change i18n setup to use locale files even for English. This was done to handle more complex strings and make one location for lang terms and easier for terms not to overlook for other lang translations.
Other changes, general code clean occur based on jsHint recommendations.