Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Make the progress bar keyboard and screen reader accessible #635 #1090

Closed
wants to merge 43 commits into from

Conversation

@rylan
Copy link
Contributor

commented Jan 31, 2014

This pull requests addresses mediaelementjs accessibility concerns (Issue #635) :

  • Controls appear if hidden if the player gets keyboard focus.
  • When the player has keyboard focus, the controls will not disappear.
  • The volume slider is now has keyboard and assertive technology support.
  • The Progress bar is now has keyboard and assertive technology support.

Change i18n setup to use locale files even for English. This was done to handle more complex strings and make one location for lang terms and easier for terms not to overlook for other lang translations.

Other changes, general code clean occur based on jsHint recommendations.

Rylan Cottrell and others added 30 commits Jan 19, 2014
Rylan Cottrell Rylan Cottrell
Auto-generated id's are unique to the document. Fixes duplicate key e…
…rror by ensuring the media player's auto-generated container id is unique to the document.
javis
Initial Commit for making the time slider accessible. Changed it to b…
…e an anchor element for discoverability (READ: USE SEMANTIC MARKUP) and added in keyboard support. Gave the anchor the appropiate ARIA attributes and ROLE property for screen readers.

Also added a CSS class for offscreen text. Used this to add some offscreen text to discribe how to use the keyboard to seek the current video.
Rylan Cottrell Rylan Cottrell
Improved language terms, added support for spanish, french, idonesian…
…, trukish, arabic, italian and portuguese.
Rylan Cottrell Rylan Cottrell
Improved language terms, added support for spanish, french, idonesian…
…, trukish, arabic, italian and portuguese.
Rylan Cottrell Rylan Cottrell
Merge tag '2.13.2' of https://github.com/johndyer/mediaelement into a…
…ccessibility

Conflicts:
	build/mediaelement-and-player.js
	build/mediaelement-and-player.min.js
	build/mediaelement.js
	build/mediaelement.min.js
	build/mediaelementplayer.js
	build/mediaelementplayer.min.js
	src/js/me-namespace.js
Rylan Cottrell and others added 13 commits Jan 28, 2014
javis
Some minor cleanup changes to the slider. Also adding language suppor…
…t for labels added.

Added Home/End support to jump to the begining/end of the video.
Changed the up & down behaviour to be skip by 10% of the time instead of 10 seconds.
Added support for restarting the player when on the slider control (space+enter)
Made the video player respect its current state (if paused when started stays paused, if playing playing restarts)
javis
Adding a offscreen span at the top of the Video Player. This is done …
…so that screen readers will have some context of the application they are hitting.

From my testing NVDA would not read ARIA-LABEL's when something has role=application.
javis
Merge branch 'accessibility' of https://github.com/rylan/mediaelement
Conflicts:
	src/js/me-i18n-locale-en.js
	src/js/mep-feature-progress.js
@rylan

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2014

I am going to close this pull request for now as we have found a couple cases where screen readers are not behaving as we would like. I will resubmit once we have a fix for those cases, which should hopefully allow us to also include our work on Captions and subtitles as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.