Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"splice is not a function" fix on MEP.remove() [follow-up from #779 and #788] #799

Merged
merged 1 commit into from
Apr 10, 2013
Merged

"splice is not a function" fix on MEP.remove() [follow-up from #779 and #788] #799

merged 1 commit into from
Apr 10, 2013

Commits on Mar 15, 2013

  1. Follow-up from #779 and #788 

    #788 tried to fix part of what #779 did, but didn't acknowledge that
`mejs.players` is no longer an array, being an object now (a change
introduced by #779). As such, remove() now throws a "splice is not
defined" error at that point.

This fix replaces the line added by #788 with #779's equivalent, but
preserves (and rectifies) the comment above.
    @odnamrataizem
    odnamrataizem committed Mar 15, 2013
    Configuration menu
    Copy the full SHA
    efe5438 View commit details
    Browse the repository at this point in the history