Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight naming change #19

Closed
Yomguithereal opened this issue Dec 13, 2018 · 2 comments
Closed

Slight naming change #19

Yomguithereal opened this issue Dec 13, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@Yomguithereal
Copy link
Member

@boogheta @farjasju:

should we change extract_urls and extract_urls_from_html to urls_from_text and urls_from_html? And later add links_from_html with the link's title & url in a tuple?
@Yomguithereal Yomguithereal added the enhancement New feature or request label Dec 13, 2018
@boogheta
Copy link
Member

sounds good to me

@farjasju
Copy link
Collaborator

much clearer indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boogheta @Yomguithereal @farjasju