Replaced data with component name. Rename generator template. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThijsTyZ
approved these changes
Jun 22, 2020
ThaNarie
reviewed
Jun 22, 2020
src/data/home.yaml
Outdated
|
|
||
| - name: 'two-col' | ||
| data: 'import!../app/component/block/two-col/data/data.yaml' | ||
| data: 'import!../app/component/block/two-col/data/paragraph.yaml' |
There was a problem hiding this comment.
The data.yaml inside the two-col folder was renamed to paragraph.yaml, so I'm not sure what you mean.
There was a problem hiding this comment.
was renamed to paragraph.yaml
it should have been called two-col.yaml
ThaNarie
requested changes
Jun 23, 2020
There was a problem hiding this comment.
I think there are also references in the documentation that should be updated to reflect this change.
Quick search (but could be more):
https://github.com/mediamonks/muban/search?q=data.yaml&unscoped_q=data.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.