Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced data with component name. Rename generator template. #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replaced data with component name. Rename generator template. #148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a110656
Replaced data with component name. Rename generator template.
lucastuozzo Jun 22, 2020
06436bd
Fixed two-col.yaml naming.
lucastuozzo Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...emplate/block/{name_sc}/data/default.yaml → ...plate/block/{name_sc}/data/{name-sc}.yaml
View file
Open in desktop
File renamed without changes.
0 ...mponent/block/paragraph/data/data-en.yaml → ...nt/block/paragraph/data/paragraph-en.yaml
View file
Open in desktop
File renamed without changes.
0 ...mponent/block/paragraph/data/data-nl.yaml → ...nt/block/paragraph/data/paragraph-nl.yaml
View file
Open in desktop
File renamed without changes.
0 ...ent/block/paragraph/data/data-simple.json → ...lock/paragraph/data/paragraph-simple.json
View file
Open in desktop
File renamed without changes.
0 ...pp/component/block/paragraph/data/data.js → ...mponent/block/paragraph/data/paragraph.js
View file
Open in desktop
File renamed without changes.
0 .../component/block/paragraph/data/data.yaml → ...onent/block/paragraph/data/paragraph.yaml
View file
Open in desktop
File renamed without changes.
0 ...pp/component/block/two-col/data/data.yaml → ...mponent/block/two-col/data/paragraph.yaml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/data/about.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ blocks:
data: {}

- name: "paragraph"
data: "import!../app/component/block/paragraph/data/data.yaml"
data: "import!../app/component/block/paragraph/data/paragraph.yaml"
6 changes: 3 additions & 3 deletions src/data/home.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ blocks:
data: {}

- name: "paragraph"
data: "import!../app/component/block/paragraph/data/data.yaml"
data: "import!../app/component/block/paragraph/data/paragraph.yaml"

- name: "paragraph"
data: "import!../app/component/block/paragraph/data/data-${language}.yaml"
data: "import!../app/component/block/paragraph/data/paragraph-${language}.yaml"

- name: 'two-col'
data: 'import!../app/component/block/two-col/data/data.yaml'
data: 'import!../app/component/block/two-col/data/paragraph.yaml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong file rename

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data.yaml inside the two-col folder was renamed to paragraph.yaml, so I'm not sure what you mean.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was renamed to paragraph.yaml

it should have been called two-col.yaml

2 changes: 1 addition & 1 deletion src/data/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = () => ({
},
{
name: 'paragraph',
data: 'import!../app/component/block/paragraph/data/data.js',
data: 'import!../app/component/block/paragraph/data/paragraph.js',
},
],
});