Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Select the first image in a multi-image file format such as tiff when… #243

Merged
merged 1 commit into from Nov 15, 2017

Conversation

fmeisschaert
Copy link
Contributor

… generating a still.

Imagemagick convert will create dest-1.jpeg, dest-2.jpeg, ... when detecting multiple images in a tiff file. Since a single file "dest.jpeg" is expected still generation will fail. So by explicitly selecting the first image in yjr source we can be sure that there will always be a single "dest.jpeg". This works also in the case of a jpeg source where there is only one image possible for 1 file. (A noop)

There is also an added benefit. Some professional camera's add a lowres image to a tiff file with a corrupt exif directory. By selecting only the first highres image the "convert" command will not fail in this situation.

@rblanker
Copy link
Collaborator

Thank you. I will have a look at this and run our unit tests to see everything still works. I'm not sure if this will work for images that are not multiple-image?

@fmeisschaert
Copy link
Contributor Author

fmeisschaert commented Nov 14, 2017 via email

@rblanker rblanker merged commit 283b819 into mediamosa:master Nov 15, 2017
@rblanker
Copy link
Collaborator

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants