Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research if armeabi-v7a APK is still needed #276

Open
latin-panda opened this issue May 26, 2022 · 1 comment
Open

Research if armeabi-v7a APK is still needed #276

latin-panda opened this issue May 26, 2022 · 1 comment
Labels
Type: Technical issue Improve something that users won't notice

Comments

@latin-panda
Copy link
Contributor

Describe the issue
Previously we used to generate 3 APK
Screen Shot 2022-05-26 at 5 09 54 pm

After removing XWalk we now generate 2 APK for WebView:
Screen Shot 2022-05-26 at 5 11 29 pm

If we try to publish these two in Play Store, then we get the following error:
Screen Shot 2022-05-25 at 5 42 01 pm (1)
Screen Shot 2022-05-26 at 5 08 37 pm

The 100009900 corresponds to the armeabi-v7a one and 100009901 corresponds to arm64-v8a. The error goes away if we only publish cht-android-v1.0.0-unbranded-arm64-v8a-release.apk.

Research if we still need the armeabi-v7a architecture. If we don't need it anymore then remove this architecture so we only generate 1 APK.

We were ignoring WebView armeabi-v7a before, see how we weren't including this in the github release and how it was commented in fastlane

@latin-panda latin-panda added the Type: Technical issue Improve something that users won't notice label May 26, 2022
@jkuester
Copy link
Contributor

jkuester commented May 9, 2024

Just adding some context from a recent Slack thread:

We should be able to attach multiple apks to a release as long as the apks have been built with different versionCode values. Doing that would be technically possible, but would require changes to our current CI processes. If we decide we need this support, we should also consider just packaging as an aab file since I think we could support multiple arch's from the same package that way... (Though we did back away from aabs in the past so there are probably extra challenges to deal with from that angle.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical issue Improve something that users won't notice
Projects
None yet
Development

No branches or pull requests

2 participants