200 - Bundle format and multiple secrets support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsarm
force-pushed
the
164-bundle-support
branch
from
e636750
to
d1aca9b
Compare
mrsarm
changed the title
… in publishing pipeline
…angelogs to its own page
…ing keys and actually was never used
mrsarm
force-pushed
the
164-bundle-support
branch
from
668ea10
to
957b450
Compare
|
@garethbowen , @kitsao the PR with the Alerte Niger brand was merged into master and rebased on this branch, and I have added the changes to sign that branded app with the new keystore. To test the signing and the creation of the .aab files is correct I created a draft release v0.9.0-alpha.2 , and indeed the aab were created and uploaded, and signed along the .apk versions correctly, while the rest of the branded apps are still signed with the original signature. Could you please review? |
garethbowen
approved these changes
Aug 12, 2021
| - [feature] [cht-core#6380](https://github.com/medic/cht-core/issues/6380): Adds intent so opening deployment URLs will prompt to load in app | ||
| - [improvement] [cht-android#111](https://github.com/medic/cht-android/issues/111): Compliance with Play Store developer policies for PII collection disclosure | ||
| - [bug] [cht-core#6648](https://github.com/medic/cht-core/issues/6648): Blank screen when launching external apps from CHT Android app | ||
| Checkout the release notes in the [Changelog](CHANGELOG.md) page, our you can see the full release history with the installable files for sideloading [here](https://github.com/medic/cht-android/releases). |
There was a problem hiding this comment.
Good call pulling this out!
| @@ -0,0 +1,71 @@ | |||
| # Release notes | |||
|
|
|||
| ## 0.8.0 | |||
There was a problem hiding this comment.
We need to add some documentation for 0.9.0, right?
There was a problem hiding this comment.
Yes, I'm going to add the release notes in this PR.
Co-authored-by: Gareth Bowen <gareth@medic.org>
Co-authored-by: Gareth Bowen <gareth@medic.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #200
Implement build config and CI scripts to create bundle files (
.aab) alongside.apkfiles for new apps, multiple secrets and scripts to create the secrets easily.Changes
Other changes
Minor changes in the Instrumentation tests that started to fail again apparently because a bug in the plugin that setups the AVD emulator.(this was moved to another PR)Because the PR with the new app is still in progress, to test the new keystore I have re-enabled the Demo app (disabled in the releases and the Play Store) and sign it with the new key, and also used to test the .aab generation. The alpha release v0.9.0-bundle-support.5 contains all the APKs normally created, and the new .aab files only for this flavor. Also verifying the signatures of the APKs and AABs for this flavor you will notice that they are signed with the new keystore while the rest of the APKs are signed with the Medic keystore.TO-DO
@garethbowen @kitsao despite the TO-DO could you check the PR? for sure there is a lot to fix in the README, I'm not the best writing English documentation so I hope at least you can understand how to use the new scripts. Please suggest and add all the corrections necessary.
@kitsao could you also checkout the branch, and try to create locally a new keystore following the guides? It would be a good way to test whether the instruction are clear and work, and the scripts really work outside my machine :-)